-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New content-types in artifacts preview #5555
Conversation
Nice! Small comment about the markdown view, it shouldn't say "Preview", I think that makes sense when you're actively editing something that you have the option to preview what you are working with, in this case it would be something like "Rendered" or similar. |
…ts-highlights-IFC-1127
…ts-highlights-IFC-1127
Instead of "Object", could we display the schema label? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Small nitpicking:
- changelog could be better formatted
- When clicking on
re-generate
, we could invalidate the query options of tasks count to retrigger a fetch an show the pulse
Issue: #5452
Add code viewer for new content-types, preview the raw markdown content, allow file download + copy and redesign artifact details view
Available themes are here
New copy buttons
Markdown
Yaml
JSON
Text
SVG