Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New content-types in artifacts preview #5555

Merged
merged 47 commits into from
Jan 28, 2025
Merged

Conversation

pa-lem
Copy link
Contributor

@pa-lem pa-lem commented Jan 23, 2025

Issue: #5452

Add code viewer for new content-types, preview the raw markdown content, allow file download + copy and redesign artifact details view

Available themes are here

New copy buttons
image

Markdown
Capture d’écran 2025-01-27 à 12 07 50
Capture d’écran 2025-01-27 à 12 07 54

Yaml
Capture d’écran 2025-01-27 à 12 08 24

JSON
Capture d’écran 2025-01-27 à 12 07 45

Text
Capture d’écran 2025-01-27 à 12 08 37

SVG
Capture d’écran 2025-01-27 à 12 08 01

@pa-lem pa-lem added type/feature New feature or request group/frontend Issue related to the frontend (React) labels Jan 23, 2025
@pa-lem pa-lem requested a review from bilalabbad January 23, 2025 16:34
@ogenstad
Copy link
Contributor

Nice! Small comment about the markdown view, it shouldn't say "Preview", I think that makes sense when you're actively editing something that you have the option to preview what you are working with, in this case it would be something like "Rendered" or similar.

@pa-lem pa-lem added the cd/preview Deploy preview branch label Jan 24, 2025
@bilalabbad
Copy link
Contributor

Instead of "Object", could we display the schema label?

frontend/app/src/app/router.tsx Outdated Show resolved Hide resolved
frontend/app/src/entities/artifacts/constants.ts Outdated Show resolved Hide resolved
frontend/app/src/shared/components/buttons/download.tsx Outdated Show resolved Hide resolved
Copy link
Contributor

@bilalabbad bilalabbad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Small nitpicking:

  • changelog could be better formatted
  • When clicking on re-generate, we could invalidate the query options of tasks count to retrigger a fetch an show the pulse

@pa-lem pa-lem merged commit 47f45ff into stable Jan 28, 2025
32 checks passed
@pa-lem pa-lem deleted the ple-artifacts-highlights-IFC-1127 branch January 28, 2025 15:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cd/preview Deploy preview branch group/frontend Issue related to the frontend (React) type/feature New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants