get diffs batched #5575
Merged
get diffs batched #5575
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
group/backend
CodSpeed Performance ReportMerging #5575 will not alter performanceComparing Summary
|
ajtmccarty
force-pushed
the
ajtm-01232025-limit-properties-diff
branch
2 times, most recently
from
be24506 to
0eaac74
Compare
Base automatically changed from
ajtm-01232025-limit-properties-diff
to
stable
January 27, 2025 15:26
ajtmccarty
force-pushed
the
ajtm-01242025-get-diffs-batched
branch
from
6511bcf to
aa379be
Compare
ogenstad
approved these changes
Jan 28, 2025
| @@ -42,6 +42,7 @@ async def reset_database(self, db: InfrahubDatabase, default_branch): | |||
| @pytest.fixture | |||
| def diff_repository(self, db: InfrahubDatabase) -> DiffRepository: | |||
| config.SETTINGS.database.max_depth_search_hierarchy = 10 | |||
| config.SETTINGS.database.query_size_limit = 50 | |||
There was a problem hiding this comment.
Should this fixture use a yield and return the setting back to the original value after completing the test?
There was a problem hiding this comment.
good suggestion. made this change
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
adds pagination to retrieving a saved diff. a very large diff can be over 5000 nodes, which exceeds the default pagination limit and would result in only loading part of the requested diff
this PR adds limiting to the query to retrieve a diff and handling for making sure that we use the correct limit and offsets to actually get all of the data for a given diff