Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rework documentation for atifacts and transformations #5697

Open
wants to merge 5 commits into
base: stable
Choose a base branch
from

Conversation

wvandeun
Copy link
Contributor

Recently a requirement was introduced for schemanodes to inherit from the CoreArtifactTarget generic, if you want to be able to generate artifacts for them.

To capture this in the documentation we had to redo the artifact and transformation guides. They were leveraging the BuiltinTag object to avoid having to load a custom schema into Infrahub. But a user cannot modify the schema of a BuiltinTag. Therefor we had to redo this documentation.

@wvandeun wvandeun requested a review from a team February 10, 2025 08:27
@wvandeun wvandeun self-assigned this Feb 10, 2025
@github-actions github-actions bot added the type/documentation Improvements or additions to documentation label Feb 10, 2025
Copy link
Contributor

@BeArchiTek BeArchiTek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I was confused about creating a newNetworkDevice model instead of editing the one in the demo-schema, before realizing this was meant to be a "standalone" guide.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants