Only send node mutation events when there has been a change #5763
+85
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
group/backend
CodSpeed Performance ReportMerging #5763 will not alter performanceComparing Summary
|
ogenstad
force-pushed
the
pog-mutation-events-only-on-updates-IFC-1247
branch
from
94c97ee to
26350cb
Compare
LucasG0
reviewed
Feb 17, 2025
| @@ -228,6 +228,10 @@ def updated_fields(self) -> list[str]: | |||
| """Return a list of update fields i.e. attributes and relationships""" | |||
| return list(self.relationships.keys()) + list(self.attributes.keys()) | |||
|
|
|||
| @property | |||
| def has_changes(self) -> bool: | |||
| return bool(self.updated_fields) | |||
There was a problem hiding this comment.
Nit pick but I think len(self.updated_fields) > 0 is clearer
There was a problem hiding this comment.
I think that the original is perhaps a bit more Pythonic, but either or is fine with me. I've pushed an update.
LucasG0
approved these changes
Feb 17, 2025
ogenstad
force-pushed
the
pog-mutation-events-only-on-updates-IFC-1247
branch
from
26350cb to
6a540ef
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For idempotent mutations where we don't modify an object we should not send an event.
Fixes #5760