-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FSSDK-10265] fix: UPS Lookup
& Save
during batched Decide
#374
Open
mikechu-optimizely
wants to merge
18
commits into
master
Choose a base branch
from
mike/FSSDK-10265-ups-during-batch-decide
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+233
−60
Open
Changes from all commits
Commits
Show all changes
18 commits
Select commit
Hold shift + click to select a range
963fc07
chore: updated during Rider upgrade
mikechu-optimizely d0f59b6
feat: call UPS once during batch decideForKeys or decideAll
mikechu-optimizely 14dface
revert: SaveVariation to include userProfile
mikechu-optimizely 66708d8
doc: fix param
mikechu-optimizely aa0d018
Merge branch 'master' into mike/FSSDK-10265-ups-during-batch-decide
mikechu-optimizely dd072b9
test: fix hacked tests
mikechu-optimizely f9f3f3f
revert: auto-formatting
mikechu-optimizely b43e10f
refactor: SaveToUserProfileService for simplicity
mikechu-optimizely 0dd1b74
revert: formatting
mikechu-optimizely 2b17438
bug: only SaveToUserProfileService if batch is finishing
mikechu-optimizely c9047a0
test: WIP add coverage for single `Lookup` & `Save` via USP
mikechu-optimizely dfe1367
refactor: less movement of code as the ref implementation
mikechu-optimizely 57c1ccd
Revert "refactor: less movement of code as the ref implementation"
mikechu-optimizely 9ca271c
test: finish coverage
mikechu-optimizely c97f36e
Update OptimizelySDK.Tests/OptimizelyUserContextTest.cs
mikechu-optimizely 5b7e5ae
fix: reset _userProfile after batch
mikechu-optimizely c6889e8
test: add content verification of UPS Save()
mikechu-optimizely 2f46b18
Merge remote-tracking branch 'origin/mike/FSSDK-10265-ups-during-batc…
mikechu-optimizely File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These tests look good. Wondering if we have tests covering the contents of the final UPS save call, combining all decisions in the session.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we also have the similar coverage (lookup once - save once, the ups save contents) with legacy APIs (activate, getVariation) for regression?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added coverage of the final UPS
Save
as requested.I'm researching the
Activate
andGetVariation
tests where UPS is used.