[FSSDK-11589] Add go-sdk logic to support agent for cmab #412

Mat001 · 2025-06-27T02:31:02Z

Added CMAB (Contextual Multi-Armed Bandit) support to go-sdk for Agent integration:

CMAB Service: Core service that makes HTTP calls to external CMAB prediction endpoints
CMAB Cache: LRU cache with TTL to store prediction responses and reduce API calls
CMAB Configuration: Settings for request timeouts, cache size/TTL, and retry logic with exponential backoff
Client Integration:
- Added cmabService field to OptimizelyClient
- Added WithCmabService() factory option for dependency injection
- Modified Decide() method to call CMAB service for CMAB-enabled experiments
Decision Enhancement: Extended decision responses to include CMAB predictions alongside existing feature flag results

We need CMAB support for agent in go-sdk because:

go-sdk is the core SDK - It contains all the Optimizely decision logic (bucketing, feature flags, etc.)
Agent is just a wrapper - Agent creates go-sdk clients and exposes them via HTTP endpoints
CMAB integrates with decisions - CMAB predictions need to be combined with existing feature flag logic, which lives in go-sdk's Decide()
method

This is how CMAB data flows between go-sdk and agent:

Client request → Agent's /decide HTTP endpoint
Agent → Creates Optimizely client from go-sdk (with CMAB config)
go-sdk → Makes prediction API call to CMAB service endpoint
CMAB service → Returns ML prediction response
go-sdk → Caches prediction + combines with feature flag decision
Agent → Returns combined response (feature flags + CMAB predictions) to client

Key points:

Agent creates the Optimizely client using go-sdk's factory
go-sdk handles all CMAB API calls, caching, and retry logic
Agent just passes through the enriched decision response that now includes CMAB data
The /decide endpoint response format stays the same, just with additional CMAB fields

https://jira.sso.episerver.net/browse/FSSDK-11589

…on objects

* Fix CMAB error handling to properly propagate error reasons in Decision objects * add cmab cache options to getAllOptions * fix failing fsc tests * add cmab errors file * adjust lowercase * add test * fix error message propagation in resons * add error handling to feature experiment servvice * Add more error handling to feature exper and composite feature service * nil back to err * add reasons message to composite feature service GetDecision * use AddError for reasons * Trigger PR check * remove implicit error handling - PR feedback * use nil instead of err for legacy * fix error format * Fix lint issue with fsc error * Rename error var, lint stuttering issue

pkg/client/client.go

pkg/client/factory.go

pkg/client/optimizely_decision.go

pkg/cmab/config.go

raju-opti · 2025-08-07T15:23:15Z

pkg/client/client_test.go

-func TestOptimizelyClient_handleDecisionServiceError(t *testing.T) {
-	// Create the client
-	client := &OptimizelyClient{
+// MockCmabService for testing CMAB functionality


there should be no change to this file

raju-opti · 2025-08-07T15:29:08Z

pkg/cmab/client.go

@@ -78,12 +77,6 @@ type Response struct {
 type RetryConfig struct {
 	// MaxRetries is the maximum number of retry attempts
 	MaxRetries int
-	// InitialBackoff is the initial backoff duration


we can keep the client configurable as we already have it. What I meant is we can remove these arguments from the top level cmabConfig in config.go to keep the api simpler

We can keep this file unchanged

raju-opti · 2025-08-07T15:29:39Z

pkg/cmab/client_test.go

@@ -200,10 +200,7 @@ func TestDefaultCmabClient_FetchDecision_WithRetry(t *testing.T) {
 			Timeout: 5 * time.Second,
 		},
 		RetryConfig: &RetryConfig{


and this file as well

raju-opti · 2025-08-07T15:34:06Z

pkg/decision/experiment_bucketer_service_test.go

@@ -14,105 +14,104 @@
 * limitations under the License.                                           *
 ***************************************************************************/


can we keep this file unchanged?

raju-opti · 2025-08-07T15:37:45Z

pkg/decision/composite_experiment_service.go

+	}
+}
+
+// WithCmabCacheSize sets only the CMAB cache size


We don't need these. User can just set one field in cmab.Config and use WithCmabConfig

raju-opti · 2025-08-07T15:38:30Z

pkg/decision/composite_experiment_service.go

 // CompositeExperimentService bridges together the various experiment decision services that ship by default with the SDK
 type CompositeExperimentService struct {
 	experimentServices []ExperimentService
 	overrideStore      ExperimentOverrideStore
 	userProfileService UserProfileService
+	cmabConfig         cmab.Config


would be better to use a pointer

raju-opti · 2025-08-07T15:41:34Z

pkg/decision/composite_experiment_service.go

@@ -40,11 +44,70 @@ func WithOverrideStore(overrideStore ExperimentOverrideStore) CESOptionFunc {
 	}
 }

+// WithCmabConfig merges the provided CMAB configuration with defaults.
+// Only non-zero values from the provided config will override defaults.
+func WithCmabConfig(config cmab.Config) CESOptionFunc {


can we move the merging of config to NewExperimentCmabService? NewExperimentCmabService already does some default handling. It would be better to have that in one place. For this method, we can change the parameter to *cmab.Config and just do f.cmabConfig = config

raju-opti · 2025-08-07T15:42:24Z

pkg/decision/composite_experiment_service.go

@@ -61,7 +124,10 @@ func NewCompositeExperimentService(sdkKey string, options ...CESOptionFunc) *Com
 	// 2. Whitelist
 	// 3. CMAB (always created)
 	// 4. Bucketing (with User profile integration if supplied)
-	compositeExperimentService := &CompositeExperimentService{logger: logging.GetLogger(sdkKey, "CompositeExperimentService")}
+	compositeExperimentService := &CompositeExperimentService{
+		cmabConfig: cmab.NewDefaultConfig(), // Initialize with defaults


we can remove this default initialization and handle defaults in NewExperimentCmabService as mentioned above

raju-opti · 2025-08-07T15:43:23Z

pkg/decision/experiment_cmab_service.go

-		InitialBackoff:    cmab.DefaultInitialBackoff,
-		MaxBackoff:        cmab.DefaultMaxBackoff,
-		BackoffMultiplier: cmab.DefaultBackoffMultiplier,
+func NewExperimentCmabService(sdkKey string, config cmab.Config) *ExperimentCmabService {


please change the config parameter to a pointer. Also we should handle defaults in this function as follows:

If the passed in config pointer is nil, we use default values for all config.

If the passed pointer is not nil, then we consider zero values as unconfigured and use the default value. Otherwise we use the value from the config pointer

Mat001 added 2 commits June 26, 2025 18:40

Fix CMAB error handling to properly propagate error reasons in Decisi…

54101be

…on objects

add go-sdk logic to support agent for cmab

d0c090a

optimizely-codereview-bot assigned Mat001 Jun 27, 2025

Mat001 changed the title ~~[FSSDK-] add go-sdk logic to support agent for cmab~~ [FSSDK-11589] Add go-sdk logic to support agent for cmab Jun 27, 2025

Mat001 added 26 commits June 26, 2025 19:45

cleanup debug statements

40aef5e

add cmab cache options to getAllOptions

6c419fe

fix failing fsc tests

5dcef46

add cmab errors file

1ba0e3c

adjust lowercase

c0ac22c

add test

c8b55e0

fix error message propagation in resons

8305a90

add error handling to feature experiment servvice

45d51cf

Add more error handling to feature exper and composite feature service

1e92f00

nil back to err

7bcfe8a

add reasons message to composite feature service GetDecision

d2181fb

use AddError for reasons

a76accc

Trigger PR check

2c913ba

merge in mpirnovar-fsc-failures-fix-fssdk-11649

9d57add

fix cyclomatic complexity by refactoring client.go code

a1f4b66

fix lint error

7b76378

fix lint

6a8bae4

Trigger PR check

bfe1626

remove implicit error handling - PR feedback

3221bab

add go-sdk logic to support agent for cmab

44be7aa

fix failing fsc tests

c64e543

adjust lowercase

6b5ec11

fix error message propagation in resons

d959b1a

add error handling to feature experiment servvice

c14e466

Add more error handling to feature exper and composite feature service

20967ec

Mat001 added 14 commits July 23, 2025 15:55

fix cyclomatic complexity by refactoring client.go code

7b66d8e

Trigger PR check

344a438

remove implicit error handling - PR feedback

068b036

Update license year

fe88f6a

Force GitHub refresh

5cba2f8

Merge branch 'master' into mpirnovar-cmab-gosdk-agent-fssdk-11589

3b26094

change nill to err in feat exper service

d99fa90

fix tests

e17908d

add two tests

9e40a65

Force GitHub refresh

31e2782

Add tests to address coveralls

d7bcec5

add couple more tests

06a47dd

few more tests

2763ee9

add test for TrGetCmabDecision

d5d321c

Mat001 requested review from raju-opti and jaeopt July 25, 2025 05:59

Mat001 added 9 commits July 25, 2025 10:50

fix formatting

7caa2d0

add optional CmabUUID field to OptimizelyDecision for CMAB support

2baee7e

simplify cmab agent support in go-sdk

1ad729f

Add CMAB config struct and constants

3778039

fix tests

dfbff72

cleanup

41d25e2

format

5b1f9a8

add tests for coveralls

c3cbc03

add new etst and format

1682033

raju-opti requested changes Aug 6, 2025

View reviewed changes

pkg/client/client.go Outdated Show resolved Hide resolved

pkg/client/factory.go Outdated Show resolved Hide resolved

pkg/client/optimizely_decision.go Outdated Show resolved Hide resolved

pkg/cmab/config.go Outdated Show resolved Hide resolved

Mat001 added 2 commits August 6, 2025 10:26

Add CMAB support with config merging and remove CmabUUID from public API

dcf46f6

fix low test coverage

314ea2e

Mat001 requested a review from raju-opti August 6, 2025 17:50

raju-opti requested changes Aug 7, 2025

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

[FSSDK-11589] Add go-sdk logic to support agent for cmab #412

[FSSDK-11589] Add go-sdk logic to support agent for cmab #412

Uh oh!

Mat001 commented Jun 27, 2025 •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

raju-opti Aug 7, 2025

Uh oh!

raju-opti Aug 7, 2025

Uh oh!

raju-opti Aug 7, 2025

Uh oh!

raju-opti Aug 7, 2025

Uh oh!

raju-opti Aug 7, 2025

Uh oh!

raju-opti Aug 7, 2025

Uh oh!

raju-opti Aug 7, 2025

Uh oh!

raju-opti Aug 7, 2025

Uh oh!

raju-opti Aug 7, 2025

Uh oh!

raju-opti Aug 7, 2025

Uh oh!

Uh oh!

		@@ -14,105 +14,104 @@
		* limitations under the License. *
		***************************************************************************/

[FSSDK-11589] Add go-sdk logic to support agent for cmab #412

Are you sure you want to change the base?

[FSSDK-11589] Add go-sdk logic to support agent for cmab #412

Uh oh!

Conversation

Mat001 commented Jun 27, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Added CMAB (Contextual Multi-Armed Bandit) support to go-sdk for Agent integration:

We need CMAB support for agent in go-sdk because:

This is how CMAB data flows between go-sdk and agent:

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Mat001 commented Jun 27, 2025 •

edited

Loading