-
Notifications
You must be signed in to change notification settings - Fork 37
[FSSDK-11458] Python - Add SDK Multi-Region Support for Data Hosting #459
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
36 commits
Select commit
Hold shift + click to select a range
d9e8f83
[FSSDK-11458] Python - Add SDK Multi-Region Support for Data Hosting
esrakartalOpt 0866962
Fix lint issues
esrakartalOpt 5a0e19d
Fix lint issue
esrakartalOpt 730fede
Fix errors
esrakartalOpt 47ccb94
Add region on base test
esrakartalOpt a7d74ac
Update Region as enum
esrakartalOpt 8a65e0f
Delete blank lines
esrakartalOpt 24d2fcd
Fix lint issue
esrakartalOpt ba5beee
Fix lint issue
esrakartalOpt 17c9280
Fix test errors
esrakartalOpt 155ab25
Add enum
esrakartalOpt ba049b6
Fix region value
esrakartalOpt a777fa0
Fix type issue
esrakartalOpt c1f1693
Correct the event url
esrakartalOpt 6de0889
Add region in params
esrakartalOpt 83afabe
Fix region param
esrakartalOpt 158aab3
Add region to create
esrakartalOpt 0a0cdef
Fix test cases
esrakartalOpt f68d678
Fix test cases
esrakartalOpt 81cd042
Fix lint
esrakartalOpt 9d2c892
Add region
esrakartalOpt 3c1332f
Fix test cases
esrakartalOpt 11523cf
Fix tests
esrakartalOpt 1af68db
Cast to string
esrakartalOpt 7a09f1d
Fix tests
esrakartalOpt 0b1e83f
Merge branch 'master' of https://github.com/optimizely/python-sdk int…
esrakartalOpt e07c1b4
Fix order
esrakartalOpt 1d61988
Remove unnecessary region implementation
esrakartalOpt e24a34e
Fix lint issues
esrakartalOpt 80365fa
Fix test cases
esrakartalOpt 174a7d0
Fix error
esrakartalOpt f83865f
Implemented reviews and added new tests
esrakartalOpt 8e92fda
Merge branch 'master' into esra/FSSDK-11458_eu_hosting
esrakartalOpt dafb205
Fix test cases
esrakartalOpt c774dde
Implement comments
esrakartalOpt c645e73
Fix lint issue
esrakartalOpt File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The fallback logic uses a string literal 'US' instead of the Region enum. Consider using
self.region = region or Region.US
for consistency with the type system.Copilot uses AI. Check for mistakes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I second htis use. If yuo have Region class somewhere, then we should call country attribute on the Region object.