Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make PreferentialGPSampler the default for preferential optimization #647

Merged
merged 2 commits into from
Oct 10, 2023

Conversation

not522
Copy link
Member

@not522 not522 commented Oct 5, 2023

Contributor License Agreement

This repository (optuna-dashboard) and Goptuna share common code.
This pull request may therefore be ported to Goptuna.
Make sure that you understand the consequences concerning licenses and check the box below if you accept the term before creating this pull request.

  • I agree this patch may be ported to Goptuna by other Goptuna contributors.

Reference Issues/PRs

Please merge #645 first.

What does this implement/fix? Explain your changes.

This PR makes PreferentialGPSampler the default sampler of preferential optimization instead of RandomSampler.

@codecov
Copy link

codecov bot commented Oct 5, 2023

Codecov Report

Merging #647 (07d2bf7) into main (09fa32b) will increase coverage by 0.12%.
Report is 12 commits behind head on main.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #647      +/-   ##
==========================================
+ Coverage   62.53%   62.65%   +0.12%     
==========================================
  Files          35       35              
  Lines        2242     2252      +10     
==========================================
+ Hits         1402     1411       +9     
- Misses        840      841       +1     
Files Coverage Δ
optuna_dashboard/preferential/_study.py 92.52% <100.00%> (+0.60%) ⬆️

... and 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Member

@contramundum53 contramundum53 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@not522 not522 force-pushed the gpsampler-default branch 4 times, most recently from 4ae9e16 to 48d9e16 Compare October 6, 2023 07:48
@not522 not522 force-pushed the gpsampler-default branch from 48d9e16 to 07d2bf7 Compare October 6, 2023 08:55
@contramundum53 contramundum53 added the enhancement New feature or request label Oct 10, 2023
@contramundum53 contramundum53 merged commit e18937d into optuna:main Oct 10, 2023
@contramundum53 contramundum53 added this to the v0.5.0 milestone Oct 10, 2023
@not522 not522 deleted the gpsampler-default branch October 11, 2023 02:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants