-
-
Notifications
You must be signed in to change notification settings - Fork 91
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fetch the data on the table to add csv download button #648
Merged
Merged
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,6 +1,8 @@ | ||
from __future__ import annotations | ||
|
||
import csv | ||
import functools | ||
import io | ||
import logging | ||
import os | ||
import typing | ||
|
@@ -447,6 +449,41 @@ | |
note.save_note_with_version(storage, study_id, trial_id, req_note_ver, req_note_body) | ||
response.status = 204 # No content | ||
return {} | ||
|
||
@app.get("/csv/<study_id:int>") | ||
def download_csv(study_id: int) -> BottleViewReturn: | ||
# TODO: Create a CSV file | ||
summary = get_study_summary(storage, study_id) | ||
if summary is None: | ||
response.status = 404 # Not found | ||
return {"reason": f"study_id={study_id} is not found"} | ||
trials = get_trials(storage, study_id) | ||
|
||
param_names = list(trials[0].params.keys()) | ||
union_user_attrs = list(trials[0].user_attrs) | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. https://github.com/optuna/optuna-dashboard/blob/main/optuna_dashboard/ts/components/TrialTable.tsx#L143 |
||
column_names = ["Number", "State", "Value"] + param_names + union_user_attrs | ||
|
||
buf = io.StringIO("") | ||
writer = csv.writer(buf) | ||
writer.writerow(column_names) | ||
for frozen_trial in trials: | ||
row = [ | ||
frozen_trial.number, | ||
frozen_trial.state, | ||
frozen_trial.values[0] | ||
] | ||
row += [frozen_trial.params[param] for param in param_names] | ||
row += [frozen_trial.user_attrs[attr] for attr in union_user_attrs] | ||
writer.writerow(row) | ||
|
||
# TODO: Set response headers | ||
response.headers["Content-Type"] = "text/csv; chatset=cp932" | ||
response.headers["Content-Disposition"] = f"attachment; filename=trials_{study_id}.csv" | ||
|
||
# TODO: Response body | ||
buf.seek(0) | ||
return buf.read() | ||
|
||
|
||
@app.get("/favicon.ico") | ||
def favicon() -> BottleViewReturn: | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To strictly follow the logic of this table (ref: https://github.com/optuna/optuna-dashboard/blob/main/optuna_dashboard/ts/components/TrialTable.tsx), it will be easy to use this class. https://github.com/optuna/optuna-dashboard/blob/main/optuna_dashboard/_cached_extra_study_property.py#L43
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To follow the original logic, there are some differences as follows: