Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add optional-dependencies for preferential optimization #652

Merged
merged 3 commits into from
Oct 10, 2023

Conversation

not522
Copy link
Member

@not522 not522 commented Oct 6, 2023

Contributor License Agreement

This repository (optuna-dashboard) and Goptuna share common code.
This pull request may therefore be ported to Goptuna.
Make sure that you understand the consequences concerning licenses and check the box below if you accept the term before creating this pull request.

  • I agree this patch may be ported to Goptuna by other Goptuna contributors.

Reference Issues/PRs

What does this implement/fix? Explain your changes.

This PR adds optional-dependencies for preferential optimization. PreferentialGPSampler requires BoTorch v0.8.1 (the latest version).

@codecov
Copy link

codecov bot commented Oct 6, 2023

Codecov Report

Merging #652 (4a68309) into main (09fa32b) will decrease coverage by 0.02%.
Report is 12 commits behind head on main.
The diff coverage is 6.25%.

@@            Coverage Diff             @@
##             main     #652      +/-   ##
==========================================
- Coverage   62.53%   62.52%   -0.02%     
==========================================
  Files          35       35              
  Lines        2242     2244       +2     
==========================================
+ Hits         1402     1403       +1     
- Misses        840      841       +1     
Files Coverage Δ
optuna_dashboard/preferential/_study.py 91.91% <ø> (ø)
optuna_dashboard/preferential/samplers/gp.py 67.98% <6.25%> (-0.16%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

pyproject.toml Outdated
@@ -54,6 +54,9 @@ optional = [
"botorch",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we add version constraint to this line also?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you. Updated.

Copy link
Member

@contramundum53 contramundum53 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@contramundum53 contramundum53 merged commit 5d3a128 into optuna:main Oct 10, 2023
3 checks passed
@contramundum53 contramundum53 added the dependencies Pull requests that update a dependency file label Oct 10, 2023
@contramundum53 contramundum53 added this to the v0.5.0 milestone Oct 10, 2023
@not522 not522 deleted the optional-dependencies branch October 11, 2023 07:48
@not522 not522 mentioned this pull request Oct 12, 2023
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants