-
-
Notifications
You must be signed in to change notification settings - Fork 91
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add optional-dependencies
for preferential optimization
#652
Conversation
Codecov Report
@@ Coverage Diff @@
## main #652 +/- ##
==========================================
- Coverage 62.53% 62.52% -0.02%
==========================================
Files 35 35
Lines 2242 2244 +2
==========================================
+ Hits 1402 1403 +1
- Misses 840 841 +1
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
pyproject.toml
Outdated
@@ -54,6 +54,9 @@ optional = [ | |||
"botorch", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we add version constraint to this line also?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you. Updated.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Contributor License Agreement
This repository (
optuna-dashboard
) and Goptuna share common code.This pull request may therefore be ported to Goptuna.
Make sure that you understand the consequences concerning licenses and check the box below if you accept the term before creating this pull request.
Reference Issues/PRs
What does this implement/fix? Explain your changes.
This PR adds
optional-dependencies
for preferential optimization.PreferentialGPSampler
requires BoTorch v0.8.1 (the latest version).