Add 3js artifact viewer to obj loader #669
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hrntsm
commented
Oct 23, 2023
| artifact.filename.endsWith(".stl") || artifact.filename.endsWith(".3dm") | ||
| artifact.filename.endsWith(".stl") || | ||
| artifact.filename.endsWith(".3dm") || | ||
| artifact.filename.endsWith(".obj") |
There was a problem hiding this comment.
Since the obj extension is also present in files other than 3D models, should I make mimetype(model/obj) a criterion as well?
Codecov Report
@@ Coverage Diff @@
## main #669 +/- ##
==========================================
+ Coverage 62.65% 62.88% +0.23%
==========================================
Files 35 35
Lines 2252 2250 -2
==========================================
+ Hits 1411 1415 +4
+ Misses 841 835 -6
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contributor License Agreement
This repository (
optuna-dashboard) and Goptuna share common code.This pull request may therefore be ported to Goptuna.
Make sure that you understand the consequences concerning licenses and check the box below if you accept the term before creating this pull request.
Reference Issues/PRs
followup #552
What does this implement/fix? Explain your changes.
Support for displaying OBJ format files