-
-
Notifications
You must be signed in to change notification settings - Fork 92
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add E2E tests for preferential optimization #691
Add E2E tests for preferential optimization #691
Conversation
@keisuke-umezawa Could you review this PR? |
Codecov Report
@@ Coverage Diff @@
## main #691 +/- ##
=======================================
Coverage 62.88% 62.88%
=======================================
Files 35 35
Lines 2250 2250
=======================================
Hits 1415 1415
Misses 835 835 📣 Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in Chrome or Firefox today! |
@HideakiImamura Seems not to work with optuna==2.10.0. Could you check the code? |
|
@HideakiImamura |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great example of e2e test! Thank you.
@@ -83,6 +83,7 @@ $ pytest python_tests/ | |||
|
|||
``` | |||
$ pip install -r requirements.txt | |||
$ playwright install |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thx!
Contributor License Agreement
This repository (
optuna-dashboard
) and Goptuna share common code.This pull request may therefore be ported to Goptuna.
Make sure that you understand the consequences concerning licenses and check the box below if you accept the term before creating this pull request.
Reference Issues/PRs
Following #484, I add e2e tests using playwright for preferential optimization.
What does this implement/fix? Explain your changes.
This PR adds the e2e test file
test_preferential_optimization.py
. This tests the followings.The following screenshot was generated by the
playwright --screenshot on
option.