Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable to download a csv file #722

Closed
wants to merge 3 commits into from
Closed

Conversation

eukaryo
Copy link
Contributor

@eukaryo eukaryo commented Dec 6, 2023

Contributor License Agreement

This repository (optuna-dashboard) and Goptuna share common code.
This pull request may therefore be ported to Goptuna.
Make sure that you understand the consequences concerning licenses and check the box below if you accept the term before creating this pull request.

  • I agree this patch may be ported to Goptuna by other Goptuna contributors.

Reference Issues/PRs

I will take over this PR:
#648

What does this implement/fix? Explain your changes.

  • added a function to make a csv file in backend.
  • added a button to download the file in frontend. (in the bottom of TrialTable page)

Copy link

codecov bot commented Dec 6, 2023

Codecov Report

Attention: 40 lines in your changes are missing coverage. Please review.

Comparison is base (9e314a9) 67.20% compared to head (3c11fb7) 66.13%.
Report is 19 commits behind head on main.

Files Patch % Lines
optuna_dashboard/_app.py 9.09% 40 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #722      +/-   ##
==========================================
- Coverage   67.20%   66.13%   -1.07%     
==========================================
  Files          35       35              
  Lines        2293     2336      +43     
==========================================
+ Hits         1541     1545       +4     
- Misses        752      791      +39     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@c-bata c-bata self-assigned this Dec 6, 2023
@c-bata
Copy link
Member

c-bata commented Dec 6, 2023

@eukaryo Thank you for your pull request! I took a brief look at the PR and it seems like the changes made by RuTiO2le also appear as a patch written by you. Could you fetch the RuTiO2le:code-fix/download_csv branch and make additional changes on top of that?

$ gh pr checkout 648
$ vim ... # Add changes
$ git add .
$ git commit
$ git push eukaryo code-fix/download_csv

@eukaryo
Copy link
Contributor Author

eukaryo commented Dec 6, 2023

Sorry, I see. I close this PR and create another one.

@eukaryo eukaryo closed this Dec 6, 2023
@eukaryo eukaryo deleted the csv-download branch December 6, 2023 07:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants