Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show loading message while loading StudySummaries #760

Merged
merged 2 commits into from
Jan 24, 2024

Conversation

y0z
Copy link
Member

@y0z y0z commented Jan 18, 2024

Contributor License Agreement

This repository (optuna-dashboard) and Goptuna share common code.
This pull request may therefore be ported to Goptuna.
Make sure that you understand the consequences concerning licenses and check the box below if you accept the term before creating this pull request.

  • I agree this patch may be ported to Goptuna by other Goptuna contributors.

Reference Issues/PRs

What does this implement/fix? Explain your changes.

  • Add a state to manage whether the study list is loading
  • Show a loading message based on the state

out

@c-bata c-bata self-assigned this Jan 18, 2024
Copy link
Member

@c-bata c-bata left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your pull request. Looks almost good to me. I left one minor comment.

optuna_dashboard/ts/components/StudyList.tsx Outdated Show resolved Hide resolved
Copy link

codecov bot commented Jan 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (9b64a63) 69.48% compared to head (ac1e1b6) 69.48%.
Report is 36 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #760   +/-   ##
=======================================
  Coverage   69.48%   69.48%           
=======================================
  Files          35       35           
  Lines        2353     2353           
=======================================
  Hits         1635     1635           
  Misses        718      718           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@y0z
Copy link
Member Author

y0z commented Jan 24, 2024

I have applied all comments. PTAL.

Copy link
Member

@c-bata c-bata left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you for your pull request.

@c-bata c-bata merged commit d7c7791 into optuna:main Jan 24, 2024
10 checks passed
@y0z y0z deleted the feature/add-loading-for-large-study branch January 24, 2024 02:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

add progress bar when loading a study
2 participants