Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update import path #213

Merged
merged 3 commits into from
Oct 30, 2023
Merged

Update import path #213

merged 3 commits into from
Oct 30, 2023

Conversation

Alnusjaponica
Copy link
Collaborator

Motivation

Resolve optuna/optuna#4935

Description of the changes

Replace import path from pytorch_lightning to lightning.pytirch.
Note that the tests passes after optuna/optuna#5028 is merged

@github-actions
Copy link

This pull request has not seen any recent activity.

@github-actions github-actions bot added the stale Exempt from stale bot labeling. label Oct 19, 2023
@Alnusjaponica Alnusjaponica removed the stale Exempt from stale bot labeling. label Oct 20, 2023
@Alnusjaponica Alnusjaponica marked this pull request as ready for review October 25, 2023 02:02
@Alnusjaponica
Copy link
Collaborator Author

Now that optuna/optuna#4935 is merged into master and the tests pass.
@HideakiImamura Could you assign a reviewer?

not522
not522 approved these changes Oct 30, 2023
View reviewed changes
Copy link
Member

@not522 not522 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@not522 not522 added this to the v3.5.0 milestone Oct 30, 2023
@not522 not522 merged commit 3468c8c into optuna:main Oct 30, 2023
5 checks passed
@Alnusjaponica Alnusjaponica deleted the fix-lightning-import-path branch October 30, 2023 01:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@not522 not522 not522 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v3.5.0
Development

Successfully merging this pull request may close these issues.

Import lightning.pytorch instead of pytorch_lightning
2 participants
@Alnusjaponica @not522