Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add simples examples for multi-objective and constrained optimizations #216

Merged
merged 3 commits into from
Oct 19, 2023

Conversation

nabenabe0928
Copy link
Collaborator

Motivation

I added simple examples for multi-objective and constrained optimizations.

Description of the changes

@contramundum53
Copy link
Member

@Alnusjaponica Could you review this PR?

README.md Outdated
Comment on lines 9 to 10
- [Quadratic multi-objective function](./quadratic_simple_multi_objective.py)
- [Quadratic function with constraints](./quadratic_simple_constraint.py)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This repository already contains examples of multi-objective optimization within the multi_objective directory. Would it be possible to move these examples to that location for consistency?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will do it!

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!
A nit-picky, but multi_objective/quadratic_simple_multi_objective.py might sound verbose since multi_objective is duplicated.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Addressed!

Copy link
Collaborator

@Alnusjaponica Alnusjaponica left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Alnusjaponica Alnusjaponica added this to the v3.5.0 milestone Oct 19, 2023
@Alnusjaponica Alnusjaponica merged commit 1486d10 into optuna:main Oct 19, 2023
5 checks passed
Comment on lines +9 to +10
- [Quadratic multi-objective function](./multi_objective/quadratic_simple.py)
- [Quadratic function with constraints](./quadratic_simple_constraint.py)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like * should be used for listing

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch! if necessary, I'm happy to include this too in #217 as a followup.

Copy link
Collaborator

@Alnusjaponica Alnusjaponica Oct 19, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the comment! I appreciate your follow-up.

Copy link
Member

@nzw0301 nzw0301 Oct 19, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your response; I've updated the PR!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants