-
Notifications
You must be signed in to change notification settings - Fork 177
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add simples examples for multi-objective and constrained optimizations #216
Add simples examples for multi-objective and constrained optimizations #216
Conversation
@Alnusjaponica Could you review this PR? |
README.md
Outdated
- [Quadratic multi-objective function](./quadratic_simple_multi_objective.py) | ||
- [Quadratic function with constraints](./quadratic_simple_constraint.py) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This repository already contains examples of multi-objective optimization within the multi_objective
directory. Would it be possible to move these examples to that location for consistency?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I will do it!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
A nit-picky, but multi_objective/quadratic_simple_multi_objective.py
might sound verbose since multi_objective
is duplicated.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Addressed!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
- [Quadratic multi-objective function](./multi_objective/quadratic_simple.py) | ||
- [Quadratic function with constraints](./quadratic_simple_constraint.py) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems like *
should be used for listing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice catch! if necessary, I'm happy to include this too in #217 as a followup.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the comment! I appreciate your follow-up.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for your response; I've updated the PR!
Motivation
I added simple examples for multi-objective and constrained optimizations.
Description of the changes