Add OptunaSearchCV with terminator
#225
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Alnusjaponica
force-pushed
the
add-terminator-search-cv
branch
from
a5304ce to
fc17336
Compare
Alnusjaponica
force-pushed
the
add-terminator-search-cv
branch
from
fc17336 to
6194ac9
Compare
|
@nabenabe0928 Could you review this PR? |
|
@Alnusjaponica Could you update README.md to add a link? |
Yes |
|
@c-bata I updated |
|
@Alnusjaponica Thank you for the update! @nabenabe0928 Could you please let me know once you approve? I'll then merge this PR. |
nabenabe0928
approved these changes
Nov 16, 2023
HideakiImamura
approved these changes
Nov 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Thanks to optuna/optuna#5098, now we can use terminator in
OptunaSearchCV. This example shows how to use it.Description of the changes
The example itself is basically the same as
sklearn/sklearn_optuna_search_cv_simple.pyexcept thatTerminatorCallbackwith default setting is passed toOptunaSearchCV.I added the example under
terminator/so that we don't have to change dependency of each module.