Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Separate basic and faq directories #277

Merged
merged 4 commits into from
Aug 13, 2024
Merged

Separate basic and faq directories #277

merged 4 commits into from
Aug 13, 2024

Conversation

kAIto47802
Copy link
Collaborator

Motivation

The name basic_and_faq_usages is too long.

Description of the changes

  • Separate the basic_and_faq_usages directory into basic and faq.
  • Modify the corresponding workflows and README.

nabenabe0928
nabenabe0928 reviewed Aug 9, 2024
View reviewed changes
Copy link
Collaborator

@nabenabe0928 nabenabe0928 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we do not need pandas for basic.

@nabenabe0928
Copy link
Collaborator

Could you please take care of the expired link here?

@kAIto47802 kAIto47802 mentioned this pull request Aug 9, 2024
Closed
nabenabe0928
nabenabe0928 requested changes Aug 9, 2024
View reviewed changes
Copy link
Collaborator

@nabenabe0928 nabenabe0928 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Almost LGTM!

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
kAIto47802 and others added 2 commits August 13, 2024 15:29
@kAIto47802 @nabenabe0928
Update README.md
be71402 
Co-authored-by: Shuhei Watanabe <[email protected]>
@kAIto47802 @nabenabe0928
Update README.md
f7e7bbf 
Co-authored-by: Shuhei Watanabe <[email protected]>
@kAIto47802
Copy link
Collaborator Author

Thank you for your suggestion. I've fixed it.

nabenabe0928
nabenabe0928 approved these changes Aug 13, 2024
View reviewed changes
Copy link
Collaborator

@nabenabe0928 nabenabe0928 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@nabenabe0928 nabenabe0928 merged commit c9452c8 into optuna:main Aug 13, 2024
13 checks passed
@kAIto47802 kAIto47802 mentioned this pull request Aug 13, 2024
Merged
@not522 not522 added this to the v4.0.0 milestone Aug 16, 2024
@nabenabe0928 nabenabe0928 added the enhancement Change that does not break compatibility and not affect public interfaces, but improves performance label Oct 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nabenabe0928 nabenabe0928 nabenabe0928 approved these changes

Assignees
No one assigned
Labels
enhancement Change that does not break compatibility and not affect public interfaces, but improves performance
Projects
None yet
Milestone
v4.0.0
Development

Successfully merging this pull request may close these issues.
3 participants
@kAIto47802 @nabenabe0928 @not522