Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set repository url #196

Merged
merged 1 commit into from
Jan 24, 2025
Merged

Set repository url #196

merged 1 commit into from
Jan 24, 2025

Conversation

ktns
Copy link
Contributor

@ktns ktns commented Jan 23, 2025

Motivation

Hi.

I just noticed renovate bot does not paste the release note to the PR for optuna-integration, while it does to one for optuna. I suspect that the reason is the missing repository URL in pyproject.toml.

Description of the changes

Added project.urls.repository field of pyproject.toml.

Copy link
Member

@c-bata c-bata left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you for your contribution!

It might be good to add homepage, documentation, and bugtracker fields as well. However, this could be addressed in the following pull requests.
https://github.com/optuna/optuna/blob/229fe58389a649ca90e7ee2205aeb3d648182235/pyproject.toml#L110-L113

@c-bata c-bata added the other Issue/PR that does not fit into any other label. label Jan 24, 2025
@c-bata c-bata added this to the v4.3.0 milestone Jan 24, 2025
@c-bata c-bata merged commit f0384b8 into optuna:main Jan 24, 2025
123 checks passed
@ktns ktns deleted the repository-url branch January 24, 2025 04:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
other Issue/PR that does not fit into any other label.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants