This repository has been archived by the owner on Jun 3, 2021. It is now read-only.
Changes by @DmitriyShvanyk. #6
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add svg sprites, fix js
Fix scale images and delay load twitter widget
Remove vscode files
toshihikoyanase
changed the title
|
The fonts of the first line of the PyTorch example are different from the original site. The colors of the highlighted terms in the steps are also different. before (https://optuna.org) after (https://optuna.github.io/optuna-web-dev/#code_examples) |
toshihikoyanase
commented
Apr 16, 2020
index.html
Outdated
| <div class="row" style="margin-top:0px;"> | ||
| <div class="col-md-6 ml-auto mr-auto text-center youtube"> | ||
| <iframe width="560" height="315" class="b-lazy" data-src="https://www.youtube.com/embed/J_aymk4YXhg" | ||
| title="Video 1"></iframe> |
There was a problem hiding this comment.
Suggested change
| title="Video 1"></iframe> | |
| title="Optuna: A Define by Run Hyperparameter Optimization Framework | SciPy 2019"></iframe> |
index.html
Outdated
| </div> | ||
| <div class="col-md-6 ml-auto mr-auto text-center youtube"> | ||
| <iframe width="560" height="315" class="b-lazy" data-src="https://www.youtube.com/embed/-UeC4MR3PHM" | ||
| title="Video 2"></iframe> |
There was a problem hiding this comment.
Suggested change
| title="Video 2"></iframe> | |
| title="Optuna: A Next Generation Hyperparamter Optimization Framework | KDD2019"></iframe> |
index.html
Outdated
Comment on lines
10
to
12
| <!--[if IE]> | ||
| <meta http-equiv="X-UA-Compatible" content="IE=edge,chrome=1"> | ||
| <![endif]--> |
There was a problem hiding this comment.
Please fix indent.
Suggested change
| <!--[if IE]> | |
| <meta http-equiv="X-UA-Compatible" content="IE=edge,chrome=1"> | |
| <![endif]--> | |
| <!--[if IE]> | |
| <meta http-equiv="X-UA-Compatible" content="IE=edge,chrome=1"> | |
| <![endif]--> |
assets/js/scripts.js
Outdated
| // lazy load | ||
| var bLazy = new Blazy({ | ||
| // Options | ||
| offset: 100 |
There was a problem hiding this comment.
This offset value seems to be the default of bLazy. Can we remove it?
index.html
Outdated
Comment on lines
1105
to
1114
| <script> | ||
| /*function loadPlatformTwitter() { | ||
| let body = document.querySelector('body'); | ||
| let script = document.createElement('script'); | ||
| script.async = true; | ||
| script.src = 'https://platform.twitter.com/widgets.js'; | ||
| body.appendChild(script); | ||
| }*/ | ||
| //setTimeout(() => {loadPlatformTwitter();}, 3000); | ||
| </script> |
There was a problem hiding this comment.
This script is commented out. Can we remove it?
Suggested change
| <script> | |
| /*function loadPlatformTwitter() { | |
| let body = document.querySelector('body'); | |
| let script = document.createElement('script'); | |
| script.async = true; | |
| script.src = 'https://platform.twitter.com/widgets.js'; | |
| body.appendChild(script); | |
| }*/ | |
| //setTimeout(() => {loadPlatformTwitter();}, 3000); | |
| </script> |
|
In |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR includes all the changes in #2, #3, #4 and #5.