Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove registry_root from load_module #56

Merged
merged 1 commit into from
Aug 27, 2024

Conversation

y0z
Copy link
Member

@y0z y0z commented Aug 23, 2024

Motivation & Description of the changes

Since registry_root is "package" for most users, this PR removes the registry_root argument for simplicity.

Copy link

codecov bot commented Aug 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.08%. Comparing base (e55a73d) to head (37c9a26).
Report is 10 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #56      +/-   ##
==========================================
+ Coverage   81.95%   82.08%   +0.13%     
==========================================
  Files           6        6              
  Lines         133      134       +1     
==========================================
+ Hits          109      110       +1     
  Misses         24       24              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@toshihikoyanase toshihikoyanase left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds reasonable to me.
If someone wants to change the registry_root, we can revisit this optional argument.

@toshihikoyanase toshihikoyanase merged commit 9acd6dc into optuna:main Aug 27, 2024
13 checks passed
@y0z y0z added the compatibility Change that breaks compatibility. label Aug 28, 2024
@y0z y0z added this to the v0.1.0 milestone Aug 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
compatibility Change that breaks compatibility.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants