Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce ConstrainedMixin #75

Merged
merged 15 commits into from
Dec 17, 2024
Merged

Conversation

y0z
Copy link
Member

@y0z y0z commented Dec 13, 2024

Motivation & Description of the changes

This PR introduces optunahub.benchmarks.ConstrainedMixin to create constrained optimization problems.

y0z added 2 commits December 13, 2024 15:46
@y0z y0z added the feature Change that does not break compatibility, but affects the public interfaces. label Dec 13, 2024
Copy link

codecov bot commented Dec 13, 2024

Codecov Report

Attention: Patch coverage is 90.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 88.75%. Comparing base (16853f9) to head (1cbaf7f).
Report is 17 commits behind head on main.

Files with missing lines Patch % Lines
optunahub/benchmarks/_constrained_mixin.py 88.88% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #75      +/-   ##
==========================================
+ Coverage   88.67%   88.75%   +0.07%     
==========================================
  Files           8        9       +1     
  Lines         159      169      +10     
==========================================
+ Hits          141      150       +9     
- Misses         18       19       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@y0z y0z marked this pull request as draft December 16, 2024 03:28
@y0z y0z changed the title Introduce ConstrainedMixIn Introduce ConstrainedMixin Dec 16, 2024
@y0z y0z marked this pull request as ready for review December 16, 2024 04:05
Copy link
Contributor

@nabenabe0928 nabenabe0928 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the PR, I left some comments!

y0z and others added 10 commits December 17, 2024 18:06
Co-authored-by: Shuhei Watanabe <[email protected]>
Co-authored-by: Shuhei Watanabe <[email protected]>
Co-authored-by: Shuhei Watanabe <[email protected]>
Co-authored-by: Shuhei Watanabe <[email protected]>
Co-authored-by: Shuhei Watanabe <[email protected]>
Co-authored-by: Shuhei Watanabe <[email protected]>
Co-authored-by: Shuhei Watanabe <[email protected]>
Co-authored-by: Shuhei Watanabe <[email protected]>
Copy link
Contributor

@nabenabe0928 nabenabe0928 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@nabenabe0928 nabenabe0928 merged commit 61d47cc into optuna:main Dec 17, 2024
11 checks passed
@c-bata c-bata added this to the v0.2.0 milestone Jan 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature Change that does not break compatibility, but affects the public interfaces.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants