[v1.x] slabinfo: detect circular freelists #117
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We use a set to track the freelist, but we don't actually use it to check whether we've seen the object in the freelist. If an object gets double freed, we'll enter into an infinite loop. Check this and raise an error. Since we're already detecting invalid freelist pointers as one kind of error, let's add an exception class hierarchy to represent freelist errors, and then we can put this into the slabinfo directly. Then, we can format the information in a table at the end of the slabinfo. Orabug: 37170864 Signed-off-by: Stephen Brennan <[email protected]>
oracle-contributor-agreement
bot
added
the
OCA Verified
biger410
approved these changes
Oct 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We use a set to track the freelist, but we don't actually use it to check whether we've seen the object in the freelist. If an object gets double freed, we'll enter into an infinite loop.
Check this and raise an error. Since we're already detecting invalid freelist pointers as one kind of error, let's add an exception class hierarchy to represent freelist errors, and then we can put this into the slabinfo directly. Then, we can format the information in a table at the end of the slabinfo.
Orabug: 37170864
Main branch: #110