targetcli: add portal info #149
Conversation
oracle-contributor-agreement
bot
added
the
OCA Verified
drgn_tools/targetcli.py
Outdated
| for portal in list_for_each_entry( | ||
| "struct dentry", np_dentry.d_subdirs.address_of_(), "d_child" | ||
| ): |
There was a problem hiding this comment.
Please use dentry_for_each_child() from drgn_tools/dentry.py which handles the new changes in struct dentry in Linux 6.8.
drgn_tools/targetcli.py
Outdated
| for portal in list_for_each_entry( | ||
| "struct dentry", np_dentry.d_subdirs.address_of_(), "d_child" | ||
| ): | ||
| yield portal.d_name.name.string_().decode() |
There was a problem hiding this comment.
What is the name in this case? Is it something controlled by the user? Is it guaranteed to be ASCII? Could a user include some UTF-8 encoded non-ASCII characters?
For most stuff in the kernel we can use the above because it will generally work fine. But if it's an actual user-specified string, we need to be careful. I would suggest using escape_ascii_string() here.
There was a problem hiding this comment.
Name here is configured by the user through targetcli tool and conforms to the format of "ip_address: portal_number", which, in this case, should be ASCII. But let's use escape_ascii_string() just to be safe:)
Orabug: 37444641 Signed-off-by: Richard Li <[email protected]>
richl9
force-pushed
the
richard/targetcli
branch
from
e06946a to
40a8c59
Compare
Add portal numbers for each tpg.