Github actions fix, UEK-next support, and a table fix #85
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
While UEK-next is not an officially supported release, it's going to be quite useful as a (public) resource for keeping our helpers up-to-date with the latest kernel features. Add attributes to KernelVersion to detect when a kernel is UEK-next, and ensure that the debuginfo RPM name is properly determined. Then, use that to mark CTF as compatible with UEK-next, since there are no known issues. Of course, UEK-next is not _supported_ by any means, and in fact, I expect to encounter quite a few compatibility issues in Corelens modules that need to be addressed. Signed-off-by: Stephen Brennan <[email protected]>
If the initial contents of a row are spaces (e.g. empty table header or a string with leading whitespace) then the strip() call will remove it and misalign the table. Use rstrip() so we only remove trailing whitespace. Signed-off-by: Stephen Brennan <[email protected]>
I had hoped that storing kernel and debuginfo RPMs in a cache would improve the runtime of the actions by reducing the amount of downloads. But I haven't seen much in the way of improvement on the runtime when the cache was working, and the cache has caused *several* failures for pull requests and CI. Most developers don't have push access and therefore can't use the "re-run job" button. It seems like the cache just isn't helping, so let's get rid of it. Signed-off-by: Stephen Brennan <[email protected]>
Tests fail on UEK-next currently. I have catalogued all failures, but it will be useful for developers if we can run the litevm tests against UEK-next as we fix them. Add it to the list of kernels, but keep it commented out for now. Signed-off-by: Stephen Brennan <[email protected]>
oracle-contributor-agreement
bot
added
the
OCA Verified
SIGINT and SIGPIPE are handled by Python as exceptions. It's common to get a SIGINT with a keyboard interrupt, and in these cases the user typically doesn't want a traceback, they just want to stop corelens. For broken pipe, this is relatively common for "corelens ... | head -n $num" commands where a user wants to get just the first few lines. An exception here would print more than they expect, and would be unhelpful. Handle both of these so corelens behaves more like other system utilities. Signed-off-by: Stephen Brennan <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are three separate changes here, sorry. But each is small and easy to understand.