Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed imports and code for AutoMLx 23.4.1v notebooks #386

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

dipatidar
Copy link
Contributor

No description provided.

@oracle-contributor-agreement oracle-contributor-agreement bot added the OCA Verified All contributors have signed the Oracle Contributor Agreement. label Jan 12, 2024
@dipatidar dipatidar marked this pull request as draft January 12, 2024 18:15
@dipatidar dipatidar marked this pull request as ready for review January 12, 2024 18:15
@darenr
Copy link
Member

darenr commented Jan 12, 2024

This is not backward compatible, for people that use the existing conda packs it'll break.

rather than

import automlx

the suggestion was to do

try:
  import automlx
except ModuleNotFoundError:
  import automl

something like that so older conda packs will continue to work with the refreshed notebooks

@dipatidar
Copy link
Contributor Author

The notebook runs fails on existing code with new automlx import. It required code modification in notebook for some features.

Copy link
Member

@darenr darenr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The notebooks should be changed to be compatible with both old and new module name, rather than

import automlx

which will only work on the latest version it should try/except and alias to a common name.

Also why both import automlx and then from automlx import init?

@smith-kyle
Copy link

Just a heads up, you can review notebook changes like this using GitNotebooks.

e.g. this pull request https://gitnotebooks.com/oracle-samples/oci-data-science-ai-samples/pull/386

It's free for public repos, so might be helpful for y'all.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
OCA Verified All contributors have signed the Oracle Contributor Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants