Optimize Multi-Model Configuration Retrieval Using Parallel Execution #1062
+303
−213
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mrDzurb
requested review from
darenr,
mayoor,
VipulMascarenhas,
qiuosier and
ahosler
as code owners
oracle-contributor-agreement
bot
added
the
OCA Verified
darenr
approved these changes
Feb 7, 2025
VipulMascarenhas
approved these changes
Feb 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
https://jira.oci.oraclecorp.com/browse/ODSC-68526
The
get_multimodel_compatible_shapesmethod currently calls get_config sequentially for each model in the model_ids list, leading to inefficiencies and slow execution when handling multiple models.This update refactors the method to leverage ThreadPoolExecutor for parallel execution, reducing latency and improving response times when retrieving deployment configurations for multiple models.
Additionally, all logic responsible for loading and processing the model deployment configuration has been moved into a separate class,
MultiModelDeploymentConfigLoader. This improves code isolation, making it easier to maintain and test in the future.