[ODSC-72395] Changes to support multiple container versions in AQUA #1208
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kumar-shivam-ranjan
requested review from
darenr,
mayoor,
mrDzurb,
VipulMascarenhas,
qiuosier and
ahosler
as code owners
oracle-contributor-agreement
bot
added
the
OCA Verified
|
📌 Cov diff with main: 📌 Overall coverage: |
| @@ -118,7 +118,7 @@ class AquaContainerConfig(Serializable): | |||
| evaluate (Dict[str, AquaContainerConfigItem]): Evaluation container configuration items. | |||
| """ | |||
|
|
|||
| inference: Dict[str, AquaContainerConfigItem] = Field( | |||
| inference: Dict[str, List[AquaContainerConfigItem]] = Field( | |||
There was a problem hiding this comment.
this change will break in a few places where AquaContainerConfig is used, likely in deployment.py. Can you check if that class needs changes?
There was a problem hiding this comment.
Sure , will check , thanks
|
To move forward with this PR, I think we need to clarify what happens with deprecated containers. If we update the config and mark a container as inactive, what’s the expected behavior, will the container be removed from the container registry, or will it remain available but hidden? |
|
📌 Cov diff with main: 📌 Overall coverage: |
|
📌 Cov diff with main: 📌 Overall coverage: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR is intended to update the container config reader to recognize and expose a list of all active container versions per container family. Previously, only the latest was considered. Update the deployment handler to include all available active container versions for a selected family, so the UI can populate a dropdown with multiple options.
Related PR
https://bitbucket.oci.oraclecorp.com/projects/ODSC/repos/odsc-pegasus-control-plane/pull-requests/4565/overview
Unit Tests
TODO
Test Results
CP API
ADS AQUA API