Skip to content

Conversation

vladcristi
Copy link
Member

What this PR does / why we need it:

  • adding wrappers to handle nil checks
  • grow coverage regarding unit testing

@vladcristi vladcristi requested a review from joekr September 30, 2025 11:28
@oracle-contributor-agreement oracle-contributor-agreement bot added the OCA Verified All contributors have signed the Oracle Contributor Agreement. label Sep 30, 2025
@joekr joekr added the enhancement New feature or request label Sep 30, 2025
@joekr
Copy link
Member

joekr commented Sep 30, 2025

Do you mind posting the output of the make test here? Then feel free to land.

joekr
joekr previously approved these changes Sep 30, 2025
@vladcristi
Copy link
Member Author

Unit tests output:
ok github.com/oracle/cluster-api-provider-oci/cloud/scope 22.070s coverage: 74.4% of statements
github.com/oracle/cluster-api-provider-oci/cloud/scope/mocks coverage: 0.0% of statements
github.com/oracle/cluster-api-provider-oci/cloud/services/base coverage: 0.0% of statements
github.com/oracle/cluster-api-provider-oci/cloud/services/base/mock_base coverage: 0.0% of statements
? github.com/oracle/cluster-api-provider-oci/cloud/services/compute [no test files]
github.com/oracle/cluster-api-provider-oci/cloud/services/compute/mock_compute coverage: 0.0% of statements
? github.com/oracle/cluster-api-provider-oci/cloud/services/computemanagement [no test files]
github.com/oracle/cluster-api-provider-oci/cloud/services/computemanagement/mock_computemanagement coverage: 0.0% of statements
? github.com/oracle/cluster-api-provider-oci/cloud/services/containerengine [no test files]
github.com/oracle/cluster-api-provider-oci/cloud/services/containerengine/mock_containerengine coverage: 0.0% of statements
? github.com/oracle/cluster-api-provider-oci/cloud/services/identity [no test files]
github.com/oracle/cluster-api-provider-oci/cloud/services/identity/mock_identity coverage: 0.0% of statements
? github.com/oracle/cluster-api-provider-oci/cloud/services/loadbalancer [no test files]
github.com/oracle/cluster-api-provider-oci/cloud/services/loadbalancer/mock_lb coverage: 0.0% of statements
? github.com/oracle/cluster-api-provider-oci/cloud/services/networkloadbalancer [no test files]
github.com/oracle/cluster-api-provider-oci/cloud/services/networkloadbalancer/mock_nlb coverage: 0.0% of statements
? github.com/oracle/cluster-api-provider-oci/cloud/services/vcn [no test files]
github.com/oracle/cluster-api-provider-oci/cloud/services/vcn/mock_vcn coverage: 0.0% of statements
? github.com/oracle/cluster-api-provider-oci/cloud/services/workrequests [no test files]
github.com/oracle/cluster-api-provider-oci/cloud/services/workrequests/mock_workrequests coverage: 0.0% of statements
ok github.com/oracle/cluster-api-provider-oci/cloud/util 0.988s coverage: 60.5% of statements
ok github.com/oracle/cluster-api-provider-oci/controllers 1.829s coverage: 59.2% of statements
ok github.com/oracle/cluster-api-provider-oci/exp/api/v1beta1 16.179s coverage: 15.3% of statements
ok github.com/oracle/cluster-api-provider-oci/exp/api/v1beta2 0.031s coverage: 5.8% of statements
ok github.com/oracle/cluster-api-provider-oci/exp/controllers 1.168s coverage: 56.3% of statements
github.com/oracle/cluster-api-provider-oci/feature coverage: 0.0% of statements
? github.com/oracle/cluster-api-provider-oci/version [no test files]

@vladcristi vladcristi merged commit c206fa4 into oracle:main Oct 8, 2025
1 of 2 checks passed
@vladcristi vladcristi mentioned this pull request Oct 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request OCA Verified All contributors have signed the Oracle Contributor Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants