[GR-67833] Improve -XX:FlightRecorderLogging error message for unknown tag set #11733
+21
−2
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A documentation issue in
JRF.md
indicated that we should improve our error messages for unknown tag sets for-XX:FlightRecorderLogging
. Previously, we would have printed the following:For comparison, Hotspot prints the following warning:
With this PR, we also suggest valid tag combinations. A few examples:
We only print suggestions that match all provided tags:
For completely unknown tags, we don't print any suggestions (same as before):