[GR-68664] Disallow floating reads unless FloatingReadsPhase has been run #11942
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oracle-contributor-agreement
bot
added
the
OCA Verified
graalvmbot
force-pushed
the
tkr-no-floating-reads
branch
from
e20a13b to
b17a358
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes handling of floating reads uniform. They are never introduced unless FloatingReadsPhase has been run. This only meaningful changes are in DefaultHotSpotLoweringProvider, where a few cases were still introducing FloatingReadNodes, and the use of FloatingReadsPhase during snippet preparation. Everything else is about propagating the GraphState into snippet preparation.
Benchmark results seem fine.