[GR-70014] Make native libraries layer aware #12387
Merged
+242
−30
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oracle-contributor-agreement
bot
added
the
OCA Verified
graalvmbot
force-pushed
the
scoppey/GR-70014/make-native-libraries-layer-aware
branch
from
0450109 to
6f2dbec
Compare
graalvmbot
deleted the
scoppey/GR-70014/make-native-libraries-layer-aware
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All methods from a native library need to be in the same layer, as the native library can keep track of a state in C variables. Since the native library is linked statically against each layer, the state is kept in a separate space for each layer. This means that if two methods access the same variable, but are in different layer, they will access two different instances.
In the future, the libraries might be dynamically linked, meaning the same space will be used in all layers, but for now, this is the only solution.
To do that, all native methods are included in the layer they are first seen in.