Add support for `io.etcd:jetcd-core:0.7.5` #170

linghengqian · 2023-01-12T15:06:45Z

What does this PR do?

Fixes Add support for io.etcd:jetcd-core:0.7.5 #164 .
I have set some org.junit.jupiter.api.Disabled non-permanently, one of them is from org.mockito:mockito-core:4.11.0 Bug, I have opened the corresponding issue ArgumentMatchers#argThat does not work properly when executing GraalVM's NativeTest with the ProxyMockMaker plugin mockito/mockito#2862 yet. Four of them seem to be due to Add param of withBindVolumn for EtcdClusterExtension etcd-io/jetcd#1092 . Two of them seem to be known test bugs of jetcd-core, because these tests fail to run in JIT. These things seem to be resolved by future updates of Junit and Mockito.
I also marked all org.junit.jupiter.api.Timeout annotations temporarily removed, because using this class will cause tests to fail under NativeTest. Looks like a later version of Junit will fix it.

Checklist before merging

I have properly formatted metadata files (see CONTRIBUTING document)
I have added thorough tests. (see this)

linghengqian · 2023-01-17T11:26:53Z

One test had a too short timeout of 30 seconds. I'll deal with it in another Commit.
Update: Done.

linghengqian · 2023-01-21T02:32:48Z

I need to start to modify this PR tomorrow, because I am not near the work computer on vacation these days.
Something unexpected happened after fixing checkstyle's CI.

linghengqian · 2023-01-21T14:45:28Z

CI's Error Log seems to be due to external reasons, which have nothing to do with me. Refer to https://github.com/oracle/graalvm-reachability-metadata/actions/runs/3975259643/jobs/6815005161 .

Error: Could not find GraalVM dev build for Java 17. It may no longer be available, so please consider upgrading the Java version. If you think this is a mistake, please file an issue at: https://github.com/graalvm/setup-graalvm/issues.

linghengqian · 2023-01-25T11:07:42Z

@dnestoro @vjovanov

I checked https://github.com/oracle/graalvm-reachability-metadata/blob/237c9297016a638436c011c9696d60254bd43a92/.github/workflows/test-changed-metadata.yml , but I'm not quite sure how to put java-version: 'dev ' to test-changed-metadata.yml. The functions of Github Actions do not seem to be as powerful as I understand.
Does this require me to open a new issue in the current Git to discuss how to fix CI according to Allow java-version: 'dev' for GraalVM dev builds graalvm/setup-graalvm#31 ?

linghengqian · 2023-02-04T17:21:18Z

I also temporarily turned on metadataRepository 0.2.5. If I don't turn it on, Netty prevents the native image from compiling, I don't know why.

This issue is addressed in another PR. Refer to Fix "requires" clauses being ignored #214 .

metadata/io.etcd/jetcd-core/0.7.5/resource-config.json

gradinac · 2023-02-09T15:54:41Z

tests/src/io.etcd/jetcd-core/0.7.5/src/test/java/io/etcd/jetcd/impl/WatchUnitTest.java

+import static org.mockito.Mockito.verify;
+
+@SuppressWarnings({"SameParameterValue", "ResultOfMethodCallIgnored"})
+// `@org.junit.jupiter.api.Timeout(value = 30)` can't be used in the nativeTest GraalVM CE 22.3


Hmm, this may be interesting for our JUnit testing support, do you by any chance remember why @Timeout didn't work?

I just need to add back the @Timeout annotation of Junit at will, and the factory class of Junit will be incorrectly initialized at build time, and this cannot pass the buildArgs of --initialize-at-build-time to fix. The performance is consistent with the Error Log of the @EnabledOnOs annotation mentioned in Support testing macos/windows #24.

I'm not sure how much help Provide built-in support for GraalVM native images junit-team/junit5#3040 can provide, because that issue seems to have been silent.

gradinac · 2023-02-09T15:56:25Z

tests/src/io.etcd/jetcd-core/0.7.5/src/test/java/io/etcd/jetcd/impl/WatchUnitTest.java

+    private Watch watchClient;
+    private ExecutorService executor = Executors.newFixedThreadPool(2);
+    private AtomicReference<StreamObserver<WatchResponse>> responseObserverRef;
+    @Mock


Did you hit any issues with Mockito when writing these tests? I remember there were problems when using it with native-image

The biggest problem is that the mockito inline plugin cannot be used. I can only use the mockito subclass plugin, which I have configured in src/test/resources/mockito-extensions/org.mockito.plugins.MockMaker. Of course I also saw more weird issues at ArgumentMatchers#argThat does not work properly when executing GraalVM's NativeTest with the ProxyMockMaker plugin mockito/mockito#2862.

gradinac · 2023-02-09T16:10:39Z

tests/src/io.etcd/jetcd-core/0.7.5/src/test/java/io_etcd/jetcd_core/impl/AuthClientTest.java

+// `@org.junit.jupiter.api.Timeout(value = 30)` can't be used in the nativeTest GraalVM CE 22.3
+public class AuthClientTest {
+    @RegisterExtension
+    public static final EtcdClusterExtension cluster = EtcdClusterExtension.builder()


Does this start a Docker image that contains an Etcd cluster in the background for the purposes of testing?

Yes, io.etcd:jetcd-test:0.7.5 is a friendly utility library for launching Etcd Docker Images.

gradinac · 2023-02-09T16:20:34Z

tests/src/io.etcd/jetcd-core/0.7.5/src/test/java/io_etcd/jetcd_core/impl/SslTest.java

+import static org.assertj.core.api.Assertions.assertThat;
+
+// `@org.junit.jupiter.api.Timeout(value = 30)` can't be used in the nativeTest GraalVM CE 22.3
+@Disabled("https://github.com/etcd-io/jetcd/pull/1092")


Is there a plan to enable these tests in the future? If not, I would remove them

I think it's perfectly fine to remove these tests, as it seems jetcd-core has never been able to fix this.

If a future version of jetcd-core fixes it, that's something another issue should be talking about, not something this PR should be talking about.

gradinac · 2023-02-09T16:23:10Z

...src/io.etcd/jetcd-core/0.7.5/src/test/java/io_etcd/jetcd_core/impl/WatchTokenExpireTest.java

+            .withNodes(1)
+            .withSsl(true)
+            .withAdditionalArgs(Arrays.asList("--auth-token",
+                    "jwt,pub-key=/etc/ssl/etcd/server.pem,priv-key=/etc/ssl/etcd/server-key.pem,sign-method=RS256,ttl=1s"))


Does this refer to a path inside of the test container that EtcdClusterExtension starts?

This path refers specifically to the internal path of the Docker Image. The files corresponding to Docker Volumes are in the folder src/test/resources/ssl/cert/. Those files are manually generated under Docker Image of Linux. I've noticed that GraalVM Native Build Tools finds these files when packaging even though they don't need to be specified in resource-config.json .

linghengqian

Blocked by Add testcontainers/ryuk docker image to the allowed images list #262.

linghengqian · 2023-08-08T16:19:29Z

Late reply as I am busy these months. I will refactor the contents of this PR as required by the master branch. Until the refactoring is complete, the PR will be in a draft state.

linghengqian

I completed the nativeTest verification of io.etcd:jetcd-core:0.7.6 at Add GraalVM Reachability Metadata and corresponding nativeTest for Etcd integration apache/shardingsphere#29755. Fixing nativeTest actually only requires the GraalVM Reachability Metadata of io.netty:netty-transport-classes-epoll:4.1.99.Final.
I've opened Add support for io.netty:netty-transport-classes-epoll:4.1.99.Final #437. The current PR will be closed.

linghengqian mentioned this pull request Jan 12, 2023

Make ShardingSphere Proxy in GraalVM Native Image form available apache/shardingsphere#21347

Closed

7 tasks

linghengqian force-pushed the jetcd-core branch 5 times, most recently from 17c16e3 to 83e6767 Compare January 12, 2023 15:55

linghengqian marked this pull request as ready for review January 12, 2023 16:10

linghengqian force-pushed the jetcd-core branch 5 times, most recently from e578503 to d357171 Compare January 17, 2023 07:10

linghengqian mentioned this pull request Jan 17, 2023

Hope to update CHANGELOG etcd-io/jetcd#1091

Closed

linghengqian force-pushed the jetcd-core branch from d357171 to 4c6840a Compare January 17, 2023 07:51

dnestoro force-pushed the jetcd-core branch from 4c6840a to 9dc40e1 Compare January 17, 2023 11:19

linghengqian force-pushed the jetcd-core branch 3 times, most recently from b2e63c2 to 86f7903 Compare January 17, 2023 12:25

linghengqian mentioned this pull request Jan 19, 2023

cache2k-spring module fail when compile with native cache2k/cache2k#199

Open

linghengqian force-pushed the jetcd-core branch from 86f7903 to 1569829 Compare January 19, 2023 11:52

dnestoro requested a review from gradinac January 19, 2023 15:37

linghengqian force-pushed the jetcd-core branch 2 times, most recently from e3885a3 to 18c4b23 Compare January 21, 2023 01:58

linghengqian force-pushed the jetcd-core branch from 18c4b23 to 2a026e4 Compare January 21, 2023 14:33

linghengqian mentioned this pull request Jan 22, 2023

Unable to get GraalVM dev build for Java 17 normally graalvm/setup-graalvm#30

Closed

linghengqian force-pushed the jetcd-core branch from 2a026e4 to e193a13 Compare January 25, 2023 10:51

linghengqian requested a review from a team as a code owner January 25, 2023 10:51

linghengqian force-pushed the jetcd-core branch from e193a13 to 971eed0 Compare January 25, 2023 11:01

linghengqian force-pushed the jetcd-core branch 2 times, most recently from de0ee97 to 045b8b8 Compare January 27, 2023 15:41

linghengqian force-pushed the jetcd-core branch from 045b8b8 to 4d2a8d4 Compare February 4, 2023 16:35

linghengqian mentioned this pull request Feb 5, 2023

Fix nightly builds and release profile of ShardingSphere Proxy Native apache/shardingsphere#23957

Merged

6 tasks

linghengqian force-pushed the jetcd-core branch 3 times, most recently from 65df3ac to 6a0e33f Compare February 8, 2023 16:34

gradinac reviewed Feb 9, 2023

View reviewed changes

metadata/io.etcd/jetcd-core/0.7.5/resource-config.json Show resolved Hide resolved

gradinac reviewed Feb 9, 2023

View reviewed changes

linghengqian force-pushed the jetcd-core branch from 6a0e33f to f36775d Compare February 14, 2023 12:30

linghengqian force-pushed the jetcd-core branch 2 times, most recently from 1145a46 to 8b7a5e5 Compare April 3, 2023 17:21

linghengqian mentioned this pull request Apr 3, 2023

Add testcontainers/ryuk docker image to the allowed images list #262

Closed

2 tasks

linghengqian commented Apr 3, 2023

View reviewed changes

linghengqian force-pushed the jetcd-core branch from 8b7a5e5 to 0d4f7b5 Compare April 4, 2023 13:04

Add support for io.etcd:jetcd-core:0.7.5

a3c4244

linghengqian force-pushed the jetcd-core branch from 0d4f7b5 to a3c4244 Compare June 6, 2023 08:55

linghengqian marked this pull request as draft August 8, 2023 16:19

linghengqian commented Jan 17, 2024

View reviewed changes

linghengqian closed this Jan 17, 2024

linghengqian deleted the jetcd-core branch January 17, 2024 15:36

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add support for `io.etcd:jetcd-core:0.7.5` #170

Add support for `io.etcd:jetcd-core:0.7.5` #170

linghengqian commented Jan 12, 2023 •

edited

Loading

linghengqian commented Jan 17, 2023 •

edited

Loading

linghengqian commented Jan 21, 2023 •

edited

Loading

linghengqian commented Jan 21, 2023

linghengqian commented Jan 25, 2023

linghengqian commented Feb 4, 2023 •

edited

Loading

gradinac Feb 9, 2023

linghengqian Feb 9, 2023

gradinac Feb 9, 2023

linghengqian Feb 9, 2023

gradinac Feb 9, 2023

linghengqian Feb 9, 2023

gradinac Feb 9, 2023

linghengqian Feb 9, 2023

gradinac Feb 9, 2023

linghengqian Feb 9, 2023

linghengqian left a comment

linghengqian commented Aug 8, 2023

linghengqian left a comment

Add support for io.etcd:jetcd-core:0.7.5 #170

Add support for io.etcd:jetcd-core:0.7.5 #170

Conversation

linghengqian commented Jan 12, 2023 • edited Loading

What does this PR do?

Checklist before merging

linghengqian commented Jan 17, 2023 • edited Loading

linghengqian commented Jan 21, 2023 • edited Loading

linghengqian commented Jan 21, 2023

linghengqian commented Jan 25, 2023

linghengqian commented Feb 4, 2023 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

linghengqian left a comment

Choose a reason for hiding this comment

linghengqian commented Aug 8, 2023

linghengqian left a comment

Choose a reason for hiding this comment

Add support for `io.etcd:jetcd-core:0.7.5` #170

Add support for `io.etcd:jetcd-core:0.7.5` #170

linghengqian commented Jan 12, 2023 •

edited

Loading

linghengqian commented Jan 17, 2023 •

edited

Loading

linghengqian commented Jan 21, 2023 •

edited

Loading

linghengqian commented Feb 4, 2023 •

edited

Loading