Add support for com.github.ben-manes.caffeine:caffeine:3.1.2
#193
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
linghengqian
commented
Jan 19, 2023
There was a problem hiding this comment.
- I saw some strange Logs in https://github.com/oracle/graalvm-reachability-metadata/actions/runs/3958056122/jobs/6779170301, but I can’t see them after collecting GraalVM reachability metadata through Standard Agent Mode to any GraalVM reachability metadata entries related to
com.github.benmanes.caffeine.cache.LocalAsyncLoadingCache, and all unit tests succeed. I don't think we should bother. - Maybe a newer version of Junit 5 will fix this.
This was referenced Jan 19, 2023
vjovanov
approved these changes
Jan 20, 2023
|
@linghengqian can you please fix the style issue so I can merge? Thank you greatly for all the contributions! |
linghengqian
force-pushed
the
caffeine
branch
from
1d3f2bb to
81da84f
Compare
|
Merged
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
com.github.ben-manes.caffeine:caffeine:3.1.2#177.Checklist before merging