-
Notifications
You must be signed in to change notification settings - Fork 104
Run all tests for new libraries versions checking at once #675
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
02da616
to
0d0e042
Compare
0d0e042
to
bb4c66c
Compare
19debd3
to
4754d8d
Compare
name: "📋 Get list of all supported libraries with newer versions" | ||
permissions: write-all | ||
runs-on: "ubuntu-22.04" | ||
if: github.repository == 'oracle/graalvm-reachability-metadata' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why do we need this? What if I fork this repo?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Previously this workflow was scheduled for execution every two weeks, and therefore we didn't want this to be executed every two weeks on user's forks (we would spend their repo resources that way). We can remove it now if necessary, but I don't see a reason why this job should be executed anywhere else than in this repo.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Interesting, just leave it as a comment. Is this standard practice?
Will this prevent me from running this task manually on my fork, and should it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, that will prevent you from running this workflow on your fork (that is the purpose of this). As long as this is not a scheduled, but manually triggered job, we can remove this line. If we decide to make it scheduled at some point, I will keep this line.
Why not run this every week, after the initial manual run? |
Once we establish a quick way for fixing many tests at once, we can make this scheduled. Until then, running tests every week, while we only fixed 1 or 2 tests, will just tell us that we have same failures every week (while we spend so much resources doing that). So in my opinion, that is something for TODO list here. Once we have proper way of bulk fixing tests, we can easily make this job scheduled. |
Why not save the information about the failing builds in the repo so we don't re-run them? Then we can schedule every week to pick up the new versions that are passing. |
b361edb
to
24ada51
Compare
Update:
|
What does this PR do?
Implements: #672
Implementation details
fetchExistingLibrariesWithNewerVersions
task now returns versions grouped by library.name
) in the returned map.Note: I've changed the workflow trigger mechanism. From now on, it can only be triggered manually.