always provide revision number for xrefs #1743
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I found out this does not work yet - clicking on line number erases the revision part of the URL. Needs a bit more work. Filed that as #1745 - this is pre-existing bug. |
tarzanek
reviewed
Aug 22, 2017
| * @return location to redirect to or null if failed | ||
| */ | ||
| public String getLatestRevisionLocation() { | ||
| return new String(req.getContextPath() + Prefix.XREF_P + |
There was a problem hiding this comment.
use StringBuilder and append please
There was a problem hiding this comment.
what's the advantage of StringBuilder ? Seems less readable to me.
|
please fix the commend and merge |
|
(and thank youuuuu sir! :) ) |
|
Still need to figure out the hash URL rewrite. I suspect there is some JS meddling with the URL. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.