Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/orai-osmosis-ict #64

Merged
merged 9 commits into from
Jan 7, 2025
Merged

Conversation

ledanghuy1811
Copy link

Remove force transfer capability and add test

@ledanghuy1811 ledanghuy1811 requested a review from GNaD13 January 6, 2025 10:30
Copy link
Collaborator

@GNaD13 GNaD13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add github actions for this test

@ledanghuy1811 ledanghuy1811 force-pushed the feat/orai-osmosis-ict branch from 8f36bc4 to 2cc1186 Compare January 6, 2025 10:56
)

// TestStartOrai is a basic test to assert that spinning up a Orai network with 1 validator works properly.
func TestOraiOsmoIbc(t *testing.T) {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should name this something like TestTokenfactoryForceTransfer ...

@ledanghuy1811 ledanghuy1811 force-pushed the feat/orai-osmosis-ict branch from 8630e67 to d271763 Compare January 7, 2025 03:01
Copy link
Collaborator

@GNaD13 GNaD13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ledanghuy1811 ledanghuy1811 merged commit 972ac34 into release/v0.50.x Jan 7, 2025
10 checks passed
@ledanghuy1811 ledanghuy1811 deleted the feat/orai-osmosis-ict branch January 7, 2025 04:08
@ledanghuy1811 ledanghuy1811 restored the feat/orai-osmosis-ict branch January 7, 2025 04:11
@ledanghuy1811 ledanghuy1811 deleted the feat/orai-osmosis-ict branch January 7, 2025 04:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants