Update recurring charge request args to be uniform #390
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When calling the ShopifyAPI.REST.RecurringApplicationCharge.create
function, there's an expectation that a map with the shape
%{recurring_application_charge: map()} is passed. This is not the same
as other create calls where the outer map is provided by the requesting
logic.
This update preserves the ability to call the logic using the old
pattern as well as adds a new function that provides the ability to
create RecurringApplicationCharge records in Shopify using the same
pattern that other ShopifyAPI create functions use.
Codecov Report
@@ Coverage Diff @@
## master #390 +/- ##
=======================================
Coverage 77.11% 77.11%
=======================================
Files 33 33
Lines 485 485
=======================================
Hits 374 374
Misses 111 111 Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a simple modification that allows for arguments passed to the create function of the RecurringApplicationCharge REST module to use the same pattern for calls as other functions use. In those cases, the outer map is added by the request logic, so the caller only needs to pass the map representing the data of the struct itself.
There's some failures noted in the build, but those appear CI issues that are outside of the changes made.
Going to open this up in spite of that to raise visibility into that issue, to make sure I'm not misreading things & to get this simple modification incorporated if everything looks good.