-
-
Notifications
You must be signed in to change notification settings - Fork 55
Conversation
Some concerns discussed in #200 |
b3b219c
to
629b982
Compare
Update build
629b982
to
c57a58e
Compare
c01c310
to
92359bf
Compare
Looking really good @shamb0t! 👍 Would it be possible to split this PR into two: Feat/ipfs-dag and "Update webpack and babel" (which only upgrades the deps as you've done here)? |
We are not using the links feature of ipld. The main advantage is that we can use ipld explorer or even use path queries. This means that the |
Also regarding this, we can either use ipfs.dag.put({
...e,
next: e.next.map((cid) => ({ '/': cid })
}); While using pb you have to construct the dagNode manually using https://github.com/ipld/js-ipld-dag-pb in order to specify ipld links. Protobufs should be faster than cbor but I'm not really sure, perhaps @vmx could advise us here. |
@satazor would you want to PR the above "use IPLD links"? We define the shape of the entry objects here: https://github.com/orbitdb/ipfs-log/blob/master/src/entry.js#L30. |
Does this approach have the effect described here? #106 (comment)
|
My advise is to use dag-cbor and not using dag-pb. I hope that one day dag-pb will not be used anymore. If things don't work/are slow it should be fixed, rather then having someone using dag-pb. |
@satazor if you have the code ready, please do PR it and whoever can then cherry pick the approriate commits/changes to this PR 👍 |
Thanks for the info here guys! @satazor Feel free to open a new PR with cbor ipld links whenever you're ready and we can work from there |
Alright, I will do that either tonight or earlier in the morning. @shamb0t feel free to take on this if you want and have the time! (I'm in transit) |
closing in favour of #213 |
This PR updates ipfs.object calls to use ipfs.dag API