This repository has been archived by the owner on Sep 30, 2023. It is now read-only.
Feat: improve memory usage / allow for in-memory storage of all entries to be optional (WIP) #301
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Excited about this if it turns out to work! Would you mind though making this a draft PR until it's ready? |
mistakia
force-pushed
the
proto/record
branch
6 times, most recently
from
9f0efb9 to
39b893d
Compare
|
How are you feeling about this one @mistakia ? :) |
|
Feeling like I need to get back in the game! I plan on coming back to this in the not so distant future. |
|
Ok, I'll leave it open then 👍 |
mistakia
force-pushed
the
proto/record
branch
4 times, most recently
from
2d3f048 to
44b9a77
Compare
|
Quick status update of what I think is left. Merge the following into ipfs-log master:
After these two I can dig deeper in the benchmarks to make improvements (i.e. analyze various LRU libs)
|
mistakia
force-pushed
the
proto/record
branch
4 times, most recently
from
ad11296 to
9b765e7
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Currently, all entries (and all the data in it) are kept in memory. The goal of this PR is to make this optional in order to improve load times and performance on memory-limited environments when interacting with larger/longer log sets.
Related: #136, #203, #239
Breaking Changes
The following getters and methods become async / return promises.
log.valueslog.tailslog.tailHasheslog.get()log.traverse()log.iterator()log.toString()log.toSnapshot()Benchmarking
Before
wip
After
wip
Tradeoffs
wip
TODO