Skip to content
This repository has been archived by the owner on Apr 6, 2022. It is now read-only.

chore(republik-crowdfundings): Send payment reminders at 10pm, too #710

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

patrickvenetz
Copy link
Contributor

This Pull Request adds an additional scheduler to send payment reminders at 10pm.

(Other schedulers send reminders at 4am and 12pm.)

To send payment reminders, all payment need to be "matched" to pledge payment.

Now and then, Finance is matching payments late in the afternoon (a manual stop necessary if automatic matching fails). Yet, importing payments at 4am might lead to unmatched payments again, pushing sending reminders further off again.

@tpreusse
Copy link
Contributor

do we really want to remind people to pay us money late at night? I'd vote for 18:00 as alt slot and if our peeps work later it just doesn't immediately go out.

@patrickvenetz
Copy link
Contributor Author

Time doesn't matter IMO; we remind them at 4am, too.

@tpreusse
Copy link
Contributor

I think time matters. 4am is okey because normal people are asleep and read it in the morning. Honestly conceptually I think the best would be to not introduce a new time at all. But if they really want it – a reminder based on outdated old data, earlier is better.

@patrickvenetz
Copy link
Contributor Author

Na, pretty sure it has no effect. How about we measure whether time of day matters?

But if they really want it – a reminder based on outdated old data, earlier is better.

Not sure I understand this one. «Send mail whether or not matching is complete», is that what you mean? (Which is in blatant 180 to not sending reminders until matching is complete, when you introduce automation over a year ago.)

@tpreusse
Copy link
Contributor

tpreusse commented Jan 13, 2022

Not sure I understand this one. «Send mail whether or not matching is complete», is that what you mean? (Which is in blatant 180 to not sending reminders until matching is complete, when you introduce automation over a year ago.)

No what I'm saying is that:

  1. bank data comes in once a day, it's ready around 1am
  2. people are usually awake between 5am and 11pm, in that time frame they do their banking

The ideal time to send reminder is therefore before 5am and after 1am. This is to minimize reminders being sent while transaction might already be incoming.

The noon sending time was a compromise for our accounting to not work between 1am and 5am – which would be unnecessary. So we added an extra sending time at noon. With the risk that transactions made by humans between 5am and noon are not yet imported. If the accounting department now says that they can't work in the morning I'm fine with extending the window. But not beyond 6pm – the data is already super old at that point – no new data has come in for over 15 hours. Sending reminders based on outdated data is bad.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants