Merge pull request #1521 from orbs-network/bugfix/state-storage-updat…

…e-memory-leak

Fix state storage memory leak

services/statestorage/adapter/memory/memory_persistence.go

@@ -50,7 +50,7 @@ func NewStatePersistence(metricFactory metric.Factory) *InMemoryStatePersistence
 		fullState:  adapter.ChainState{},
 		height:     0,
 		ts:         0,
-		proposer:    []byte{},
+		proposer:   []byte{},
 		merkleRoot: merkleRoot,
 	}
 }

services/statestorage/service.go

@@ -188,15 +188,22 @@ func (s *service) GetStateHash(ctx context.Context, input *services.GetStateHash
 func inflateChainState(csd []*protocol.ContractStateDiff) adapter.ChainState {
 	result := make(adapter.ChainState)
 	for _, stateDiffs := range csd {
-		contract := stateDiffs.ContractName()
+		// copying here is very important to free up the underlying structures
+		contract := primitives.ContractName(stateDiffs.ContractName().String())
 		contractMap, ok := result[contract]
 		if !ok {
 			contractMap = make(map[string]*protocol.StateRecord)
 			result[contract] = contractMap
 		}
 		for i := stateDiffs.StateDiffsIterator(); i.HasNext(); {
 			r := i.NextStateDiffs()
-			contractMap[string(r.Key())] = r
+
+			// copying here is very important to free up the underlying structures
+			detachedBuffer := make([]byte, len(r.Raw()))
+			copy(detachedBuffer, r.Raw())
+
+			diffToApply := protocol.StateRecordReader(detachedBuffer)
+			contractMap[string(diffToApply.Key())] = diffToApply
 		}
 	}
 	return result

services/statestorage/service_test.go

@@ -0,0 +1,30 @@
+package statestorage
+
+import (
+	"github.com/orbs-network/orbs-spec/types/go/protocol"
+	"github.com/stretchr/testify/require"
+	"testing"
+)
+
+func Test_inflateChainState(t *testing.T) {
+	singleDiff := (&protocol.ContractStateDiffBuilder{
+		ContractName: "Albums",
+		StateDiffs: []*protocol.StateRecordBuilder{
+			{
+				Key:   []byte("David Bowie"),
+				Value: []byte("Station to Station"),
+			},
+		},
+	}).Build()
+
+	diffs := []*protocol.ContractStateDiff{
+		singleDiff,
+	}
+
+	chainState := inflateChainState(diffs)
+	singleDiff.StateDiffsIterator().NextStateDiffs().MutateValue([]byte("Station of Station"))
+	singleDiff.MutateContractName("Album1")
+
+	require.NotNil(t, chainState["Albums"])
+	require.EqualValues(t, []byte("Station to Station"), chainState["Albums"]["David Bowie"].Value(), "the underlying buffer was not copied")
+}