Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip memory leak tests #1347

Merged
merged 1 commit into from
Sep 25, 2019
Merged

Skip memory leak tests #1347

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions test/acceptance/memory_leak_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,7 @@ import (
// therefore, this file is marked on top with a build flag ("memoryleak") meaning without this flag it won't build or run
// to run this test, add to the go command "-tags memoryleak", this is done in test.sh while making sure it's the only test running
func TestMemoryLeaks_OnSystemShutdown(t *testing.T) {
t.Skip("This test is not useful, we only care about memory leaks during runtime and this is covered by the monitoring project 'marvin': https://github.com/orbs-network/marvin")
dir := os.Getenv("PPROF_DIR")
absPath, err := filepath.Abs("../../" + dir)

Expand Down Expand Up @@ -81,6 +82,7 @@ func TestMemoryLeaks_OnSystemShutdown(t *testing.T) {
}

func TestMemoryLeaks_DuringRuntime(t *testing.T) {
t.Skip("This test is incorrect - should modify it to take memory samples within TestGazillion instead, see https://github.com/orbs-network/orbs-network-go/issues/1346")
dir := os.Getenv("PPROF_DIR")
absPath, err := filepath.Abs("../../" + dir)

Expand Down