Issue/contract errors #275
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
netoneko
approved these changes
Sep 26, 2018
services/processor/native/service.go
Outdated
| @@ -50,7 +50,8 @@ func (s *service) ProcessCall(input *services.ProcessCallInput) (*services.Proce | |||
| contractInfo, methodInfo, err := s.retrieveContractAndMethodInfoFromRepository(executionContextId, string(input.ContractName), string(input.MethodName)) | |||
| if err != nil { | |||
| return &services.ProcessCallOutput{ | |||
| OutputArgumentArray: (&protocol.MethodArgumentArrayBuilder{}).Build(), | |||
| // TODO: discussion, showing the error string in call output will store this on the transactions on-chain but may be difficult to reproduce during audit if code changes | |||
There was a problem hiding this comment.
Errors might leak sensitive information, so I am not sure we should store it on chain.
There was a problem hiding this comment.
This is a spec decision, opened an issue there:
orbs-network/orbs-spec#97
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves orbs-network/orbs-contract-sdk#2