Improve the ts-sdk testing setup #448
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
wjthieme
commented
Nov 1, 2024
wjthieme
commented
- Add tests for fetching positions
- Use actual instructions for initializing pools/positions/tokens/etc. instead of trying to write the data ourselves
- Bankrun does not support gpa yet so some functions cannot be tested through bankrun
yugure-orca
reviewed
Nov 5, 2024
ts-sdk/whirlpool/tests/e2e.test.ts
Outdated
| const mint1 = await setupMint({ decimals: 9 }); | ||
| const mint2 = await setupMint({ decimals: 6 }); | ||
| [mintA, mintB] = | ||
| Buffer.from(mint1) < Buffer.from(mint2) ? [mint1, mint2] : [mint2, mint1]; |
ts-sdk/whirlpool/tests/pool.test.ts
Outdated
| const mint1 = await setupMint(); | ||
| const mint2 = await setupMint(); | ||
| [mintA, mintB] = | ||
| Buffer.from(mint1) < Buffer.from(mint2) ? [mint1, mint2] : [mint2, mint1]; |
| const mint1 = await setupMint(); | ||
| const mint2 = await setupMint(); | ||
| [mintA, mintB] = | ||
| Buffer.from(mint1) < Buffer.from(mint2) ? [mint1, mint2] : [mint2, mint1]; |
| [TOKEN_MINT_1]: 100n, | ||
| [TOKEN_MINT_2]: 100n, | ||
| [mintA]: 100n, | ||
| [mintB]: 100n, | ||
| [NATIVE_MINT]: 100n, |
There was a problem hiding this comment.
Just to be sure, in this case (strategy is none), the balance of ATA for native mint should be zero even if 100n is specified.
There was a problem hiding this comment.
Yep. This is how it is currently explained in the docs:
* - **None**:
* Uses or creates the ATA without performing any SOL wrapping or unwrapping.
It might make sense to throw if the balance is insufficient (also for the non-SOL mints). Basically this can be used to say: "I need x amount in this token account" and is currently only doing something for SOL (if wrapping strategy is not none). What do you think?
There was a problem hiding this comment.
Thanks for the explanation!
It makes sense🙂 (memo: the instruction requires X SOL, but my ATA already has > X SOL, so no need to wrap)
# Conflicts: # ts-sdk/whirlpool/src/pool.ts # ts-sdk/whirlpool/tests/token.test.ts
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.