Unit tests for decreaseLiquidity.ts #545
Open
+381
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
calintje
requested review from
yugure-orca,
wjthieme and
odcheung
as code owners
wjthieme
reviewed
Nov 24, 2024
|
|
||
| for (const poolName of poolTypes.keys()) { | ||
| it(`Should close the position for ${poolName}`, async () => { | ||
| await testClosePositionInstructions(poolName); |
| await assert.rejects( | ||
| decreaseLiquidityInstructions( | ||
| rpc, | ||
| positions.entries().next().value, |
There was a problem hiding this comment.
nit: Maybe hard-code the key here so it is clear which position it is getting
| const position = await setupPosition(poolAddress, { | ||
| tickLower: -100, | ||
| tickUpper: 100, | ||
| liquidity, |
There was a problem hiding this comment.
One test to close a postion without liquidity?
| await sendTransaction(instructions); | ||
|
|
||
| const positionAfter = await fetchMaybePosition(rpc, positionAddress[0]); | ||
| assert.strictEqual(positionAfter.exists, false); |
There was a problem hiding this comment.
Should we also check if fees/rewards are harvested correctly?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Title
Added unit tests for decreaseLiquidity.ts
Details
setupPositionandsetupTEPositionto support increased liquiditydecreaseLiquidity.tsdecreaseLiquidity.test.tsclosePosition.test.ts