Add increase liquidity test for rust sdk #605
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pauldragonfly
requested review from
yugure-orca,
wjthieme and
odcheung
as code owners
wjthieme
reviewed
Dec 20, 2024
|
|
||
| ctx.send_transaction_with_signers(increase_ix.instructions, signers) | ||
| .await?; | ||
|
|
There was a problem hiding this comment.
Here I would assert that the quote matches whatever happened on-chain (same way we have the test in ts sdk)
| position_bump, | ||
| }); | ||
|
|
||
| println!("Sending transaction with instructions..."); |
| @@ -237,3 +343,13 @@ pub async fn setup_position_bundle( | |||
|
|
|||
| Ok(position_bundle_address) | |||
| } | |||
|
|
|||
| pub async fn setup_config_and_fee_tiers(ctx: &RpcContext) -> Result<(), Box<dyn Error>> { | |||
There was a problem hiding this comment.
Is this used anywhere? it is not actually setting up any fee tiers and/or configs
| @@ -40,6 +40,7 @@ use crate::{SPLASH_POOL_TICK_SPACING, WHIRLPOOLS_CONFIG_ADDRESS}; | |||
| pub struct RpcContext { | |||
| pub rpc: RpcClient, | |||
| pub signer: Keypair, | |||
| pub config: Pubkey, | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add tests for increase liquidity and update RPC configurations
Changes
Details