-
Notifications
You must be signed in to change notification settings - Fork 172
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add harvest test for Rust sdk #648
Conversation
…dk-add-position-test
Remove unused config function
…-liquidity-test-rust-sdk
…d-decrese-liquidity-test-rust-sdk
…dk-add-position-test
…whirlpools into paul/add-increase-liquidity-test-rust-sdk
…m:orca-so/whirlpools into paul/add-decrese-liquidity-test-rust-sdk
…whirlpools into paul/add-increase-liquidity-test-rust-sdk
…whirlpools into paul/rust-sdk-add-position-test
…whirlpools into paul/add-increase-liquidity-test-rust-sdk
…d-decrese-liquidity-test-rust-sdk
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we do the same thing with rstest
? Otherwise looks good to me!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One small nit (that also applies to the other rstests) but LGTM!
.await | ||
.unwrap(); | ||
|
||
println!( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we still need these printlns? They different configs now show up as separate tests right?
Add Harvest Position Tests for Multi-Pool + Rewards
Scope: Added tests in harvest.rs to validate fee and reward collection for multi-pool setups.
Key Features:
Multi-Pool Coverage: Tested various pool types (e.g., A-B, A-TE) with different position ranges (centered, one-sided) for both SPL & Token-2022 mints.
Fee Generation: Incorporated swaps to accumulate fees, then verified fee_owed_a, fee_owed_b, and rewards during harvest.
Reward Collection: Validated time/emission-based reward accumulation and balances after harvesting.
Implementation: