Add tests for close position, decrease liquidity, and harvest position #653
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
pauldragonfly
commented
Jan 14, 2025
pauldragonfly
commented
- Add tests for close position
- Add tests for decrease liquidity
- Add tests for harvest position
pauldragonfly
force-pushed
the
paul/DX_100-101_add_harvest_tests_and_close_position_decrease_liquidity_tests
branch
from
5df0e68 to
bdd067f
Compare
pauldragonfly
force-pushed
the
paul/DX_100-101_add_harvest_tests_and_close_position_decrease_liquidity_tests
branch
from
bdd067f to
6010ba3
Compare
wjthieme
reviewed
Jan 16, 2025
| const tokenAAfter = await fetchToken(rpc, ataAAddress); | ||
| const tokenBAfter = await fetchToken(rpc, ataBAddress); | ||
|
|
||
| assert.strictEqual( |
There was a problem hiding this comment.
Is there anything to harvest in this case? Since the pool has no swaps the feesOwed would just be 0 I think.
One swap A->B and a swap B->A for each pool after the position is set up should do it
There was a problem hiding this comment.
Added testHarvestPositionInstructionsWithoutSwaps().
There was a problem hiding this comment.
Nice! I believe now there are only swaps from A->B which would only generate fees for token A. I think if you do the following 4 swaps you'll cover all cases:
{ inputAmount: 100n, mint: mintAAddress },
{ outputAmount: 100n, mint: mintAAddress },
{ inputAmount: 100n, mint: mintBAddress },
{ outputAmount: 100n, mint: mintBAddress },
There was a problem hiding this comment.
Modified testHarvestPositionInstructions() to test after the above 4 swaps
wjthieme
reviewed
Jan 16, 2025
| for (const poolName of poolTypes.keys()) { | ||
| for (const positionTypeName of positionTypes.keys()) { | ||
| const positionName = `${poolName} ${positionTypeName}`; | ||
| it(`Should harvest a position for ${positionName}`, async () => { | ||
| await testHarvestPositionInstructions(poolName, positionName); | ||
| }); | ||
|
|
||
| it(`Should harvest a position without swaps for ${positionName}`, async () => { |
| const tokenAAfter = await fetchToken(rpc, ataAAddress); | ||
| const tokenBAfter = await fetchToken(rpc, ataBAddress); | ||
|
|
||
| assert.strictEqual( |
There was a problem hiding this comment.
Nice! I believe now there are only swaps from A->B which would only generate fees for token A. I think if you do the following 4 swaps you'll cover all cases:
{ inputAmount: 100n, mint: mintAAddress },
{ outputAmount: 100n, mint: mintAAddress },
{ inputAmount: 100n, mint: mintBAddress },
{ outputAmount: 100n, mint: mintBAddress },
e778c6d to
7ff8403
Compare
pauldragonfly
force-pushed
the
paul/DX_100-101_add_harvest_tests_and_close_position_decrease_liquidity_tests
branch
from
7ff8403 to
41655b6
Compare
wjthieme
approved these changes
Jan 17, 2025
pauldragonfly
deleted the
paul/DX_100-101_add_harvest_tests_and_close_position_decrease_liquidity_tests
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.