Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updating fix #570

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Conversation

daminichopra
Copy link
Contributor

Proposed changes

Included a metadata field in each entity table called time_index_attribute with type array(String). Identifiedall attributes linked to the time_index. Stored the list of attributes in the field time_index_attribute. In the attribute related queries, retrieved rows where time_index_attribute includes the attribute or where time_index_attribute is Null.

Types of changes

What types of changes does your code introduce to the project: Put
an x in the boxes that apply

  • [ x ] Bugfix (non-breaking change which fixes an issue)
  • [ x ] New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing
    functionality to not work as expected)

Checklist

Put an x in the boxes that apply. You can also fill these out after
creating the PR. If you're unsure about any of them, don't hesitate to
ask. We're here to help! This is simply a reminder of what we are going
to look for before merging your code.

  • [ x ] I have read the CONTRIBUTING doc
  • [ x ] I have signed the CLA
  • [ x ] I have added tests that prove my fix is effective or that my
    feature works
  • I have added necessary documentation (if appropriate)
  • Any dependent changes have been merged and published in
    downstream modules

Further comments

Fix for Issue

@github-actions
Copy link
Contributor

github-actions bot commented Oct 7, 2021

CLA Assistant Lite bot All contributors have signed the CLA ✍️

@daminichopra
Copy link
Contributor Author

Gentle Reminder!!

@c0c0n3
Copy link
Member

c0c0n3 commented Jan 4, 2022

Hi guys, I'm struggling to make sense of this PR. I can see the implementation but I can't remember what the actual use case for this change was. Help! :-)

@daminichopra
Copy link
Contributor Author

Hi guys, I'm struggling to make sense of this PR. I can see the implementation but I can't remember what the actual use case for this change was. Help! :-)

when a new entry is recorded, the information which attributes are linked to the time_index stored is lost so we Included metadata field time_index_attribute with type array.
In this PR we identified attributes linked to the time_index and stored the list of attributes in the field time_index_attribute while storing the entity.
In attribute related queries we retrieved only rows where time_index_attribute includes the attribute or where time_index_attribute is null.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants